eslint 8.57 WIP:

* tweaking some more rules.
* fixing linting.

conversejs/build-conversejs-patch-i18n.js

@@ -4,6 +4,7 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+/* eslint-disable @typescript-eslint/no-require-imports */
 const fs = require('node:fs')
 const path = require('node:path')
 const YAML = require('yaml')

conversejs/builtin.ts

@@ -2,6 +2,8 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+/* eslint-disable @typescript-eslint/no-unsafe-function-type */
+
 import type { InitConverseJSParams, ChatIncludeMode, ExternalAuthResult } from 'shared/lib/types'
 import { inIframe } from './lib/utils'
 import { initDom } from './lib/dom'
@@ -39,7 +41,7 @@ declare global {
     }
     initConversePlugins: typeof initConversePlugins
     initConverse: typeof initConverse
-    reconnectConverse?: (room: string) => void
+    reconnectConverse?: (params: any) => void
     externalAuthGetResult?: (data: ExternalAuthResult) => void
   }
 }
@@ -86,7 +88,7 @@ window.initConversePlugins = initConversePlugins
 async function initConverse (
   initConverseParams: InitConverseJSParams,
   chatIncludeMode: ChatIncludeMode = 'chat-only',
-  peertubeAuthHeader?: { [header: string]: string } | null
+  peertubeAuthHeader?: Record<string, string> | null
 ): Promise<void> {
   // First, fixing relative websocket urls.
   if (initConverseParams.localWebsocketServiceUrl?.startsWith('/')) {
@@ -121,9 +123,9 @@ async function initConverse (
   params.view_mode = chatIncludeMode === 'chat-only' ? 'fullscreen' : 'embedded'
   params.allow_url_history_change = chatIncludeMode === 'chat-only'
 
-  let isAuthenticated: boolean = false
-  let isAuthenticatedWithExternalAccount: boolean = false
-  let isRemoteWithNicknameSet: boolean = false
+  let isAuthenticated = false
+  let isAuthenticatedWithExternalAccount = false
+  let isRemoteWithNicknameSet = false
 
   // OIDC (OpenID Connect):
   const tryOIDC = (initConverseParams.externalAuthOIDC?.length ?? 0) > 0

conversejs/custom/plugins/mam-search/templates/muc-mam-search-app.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { converseLocalizedHelpUrl } from '../../../shared/lib/help'
 import { tplMUCApp } from '../../../shared/components/muc-app/templates/muc-app.js'
 import { html } from 'lit'

conversejs/custom/plugins/mam-search/templates/muc-mam-search-message.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 
 /**

conversejs/custom/plugins/mam-search/templates/muc-mam-search-occupant.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { api } from '@converse/headless'
 import { getAuthorStyle } from '../../../../src/utils/color.js'

conversejs/custom/plugins/notes/templates/muc-note-app.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { converseLocalizedHelpUrl } from '../../../shared/lib/help'
 import { tplMUCApp } from '../../../shared/components/muc-app/templates/muc-app.js'
 import { html } from 'lit'

conversejs/custom/plugins/notes/templates/muc-note-occupant.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { api } from '@converse/headless'
 import { getAuthorStyle } from '../../../../src/utils/color.js'

conversejs/custom/plugins/notes/templates/muc-note.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { api } from '@converse/headless'
 import { html } from 'lit'
 import { __ } from 'i18n'

conversejs/custom/plugins/notes/templates/muc-notes.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { repeat } from 'lit/directives/repeat.js'
 import { __ } from 'i18n'

conversejs/custom/plugins/poll/modals/poll-form.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { __ } from 'i18n'
 import BaseModal from 'plugins/modal/modal.js'
 import { api } from '@converse/headless'

conversejs/custom/plugins/poll/templates/poll-form.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { converseLocalizedHelpUrl } from '../../../shared/lib/help'
 import { html } from 'lit'
 import { __ } from 'i18n'

conversejs/custom/plugins/poll/templates/poll.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { repeat } from 'lit/directives/repeat.js'
 import { __ } from 'i18n'

conversejs/custom/plugins/tasks/modals/templates/pick-task-list.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { repeat } from 'lit/directives/repeat.js'
 import { __ } from 'i18n'

conversejs/custom/plugins/tasks/templates/muc-task-app.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { converseLocalizedHelpUrl } from '../../../shared/lib/help'
 import { tplMUCApp } from '../../../shared/components/muc-app/templates/muc-app.js'
 import { html } from 'lit'

conversejs/custom/plugins/tasks/templates/muc-task-list.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { repeat } from 'lit/directives/repeat.js'
 import { __ } from 'i18n'

conversejs/custom/plugins/tasks/templates/muc-task-lists.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { repeat } from 'lit/directives/repeat.js'
 import { __ } from 'i18n'

conversejs/custom/plugins/tasks/templates/muc-task.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { __ } from 'i18n'
 
@@ -20,7 +23,8 @@ export function tplMucTask (el, task) {
             type="checkbox"
             class="form-check-input"
             .checked=${done === true}
-            @click=${(_ev) => {
+            @click=${(ev) => {
+              ev?.preventDefault()
               task.set('done', !done)
               task.saveItem()
             }}

conversejs/custom/plugins/terms/components/muc-terms.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { CustomElement } from 'shared/components/element.js'
 import { api } from '@converse/headless'
 import { html } from 'lit'

conversejs/custom/templates/livechat-external-login-modal.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { _converse, api } from '@converse/headless'
 import { __ } from 'i18n'
 import { html } from 'lit'
@@ -28,8 +31,9 @@ function externalLoginClickHandler (ev, el, externalAuthOIDCUrl) {
 
     console.log('Received an external authentication result...', data)
     if (!data.ok) {
-      // eslint-disable-next-line no-undef
-      el.external_auth_oidc_alert_message = __(LOC_login_external_auth_alert_message) +
+      el.external_auth_oidc_alert_message =
+        // eslint-disable-next-line no-undef
+        __(LOC_login_external_auth_alert_message) +
         (data.message ? ` (${data.message})` : '')
       return
     }

conversejs/custom/templates/muc-bottom-panel.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { __ } from 'i18n'
 import { _converse, api } from '@converse/headless'
 import { html } from 'lit'

conversejs/custom/templates/muc-chatarea.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { api } from '@converse/headless'
 import tplMUCChatarea from '../../src/plugins/muc-views/templates/muc-chatarea.js'
 import { html } from 'lit'

conversejs/custom/templates/muc-head.js

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { api } from '@converse/headless'
 import { until } from 'lit/directives/until.js'

conversejs/custom/templates/muc.js

@@ -4,6 +4,9 @@
 // SPDX-License-Identifier: MPL-2.0
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 // Must import the original muc.js, because it imports some custom elements files.
 import '../../src/plugins/muc-views/templates/muc.js'
 import { getChatRoomBodyTemplate } from '../../src/plugins/muc-views/utils.js'

conversejs/lib/auth.ts

@@ -4,7 +4,7 @@
 
 import type { ProsodyAuthentInfos } from 'shared/lib/types'
 
-interface AuthHeader { [key: string]: string }
+type AuthHeader = Record<string, string>
 
 async function getLocalAuthentInfos (
   authenticationUrl: string,
@@ -66,7 +66,7 @@ async function getLocalAuthentInfos (
           {
             'content-type': 'application/json;charset=UTF-8'
           }
-        )
+        ) as HeadersInit
       )
     })
 
@@ -104,7 +104,7 @@ async function getLocalAuthentInfos (
 function getLivechatTokenAuthInfos (): ProsodyAuthentInfos | undefined {
   try {
     const hash = window.location.hash
-    if (!hash || !hash.startsWith('#?')) { return undefined }
+    if (!hash?.startsWith('#?')) { return undefined }
     // We try to read the hash as a queryString.
     const u = new URL('http://localhost' + hash.substring(1))
     const jid = u.searchParams.get('j')

conversejs/lib/plugins/livechat-emojis.ts

@@ -17,19 +17,19 @@ export const livechatEmojisPlugin = {
       livechat_custom_emojis_url: false
     })
 
-    _converse.api.listen.on('loadEmojis', async (_context: Object, json: any) => {
-      const url = _converse.api.settings.get('livechat_custom_emojis_url')
+    _converse.api.listen.on('loadEmojis', async (_context: object, json: Record<string, Record<string, unknown>>) => {
+      const url = _converse.api.settings.get('livechat_custom_emojis_url') as string | undefined
       if (!url) {
         return json
       }
 
-      let customs
+      let customs: CustomEmojiDefinition[] | undefined
       try {
         customs = await loadCustomEmojis(url)
       } catch (err) {
         console.error(err)
       }
-      if (customs === undefined || !customs?.length) {
+      if (!customs?.length) {
         return json
       }
 
@@ -51,7 +51,7 @@ export const livechatEmojisPlugin = {
 
         // We must also remove any existing emojis in category other than custom
         for (const type of Object.keys(json)) {
-          const v: {[key: string]: any} = json[type]
+          const v: Record<string, any> = json[type]
           if (type !== 'custom' && type !== 'modifiers' && (def.sn in v)) {
             // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
             delete v[def.sn]

conversejs/lib/plugins/livechat-specific/chatroom-message.ts

@@ -2,7 +2,8 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
-export function chatRoomMessageOverrides (): {[key: string]: Function} {
+// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
+export function chatRoomMessageOverrides (): Record<string, Function> {
   return {
     /* By default, ConverseJS groups messages from the same users for a 10 minutes period.
      * This make no sense in a livechat room. So we override isFollowup to ignore. */

conversejs/lib/plugins/livechat-specific/chatroom.ts

@@ -2,7 +2,8 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
-export function chatRoomOverrides (): {[key: string]: Function} {
+// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
+export function chatRoomOverrides (): Record<string, Function> {
   return {
     getActionInfoMessage: function getActionInfoMessage (this: any, code: string, nick: string, actor: any): any {
       if (code === '303') {
@@ -27,8 +28,9 @@ export function chatRoomOverrides (): {[key: string]: Function} {
     initOccupants: function initOccupants (this: any) {
       const r = this.__super__.initOccupants()
 
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
       const originalComparatorFunction: Function = this.occupants.comparator
-      this.occupants.comparator = function (this: any, occupant1: any, occupant2: any): Number {
+      this.occupants.comparator = function (this: any, occupant1: any, occupant2: any): number {
         // Overriding Occupants comparators, to display anonymous users at the end of the list.
         const nick1: string = occupant1.getDisplayName()
         const nick2: string = occupant2.getDisplayName()

conversejs/lib/plugins/livechat-specific/message-action.ts

@@ -19,7 +19,7 @@ export function customizeMessageAction (plugin: any): void {
         try {
           txt += this.model.getDisplayName() as string
           txt += ' - '
-          const date = new Date(this.model.get('edited') || this.model.get('time'))
+          const date = new Date((this.model.get('edited') || this.model.get('time')) as string)
           txt += date.toLocaleDateString() + ' ' + date.toLocaleTimeString()
           txt += '\n'
         } catch {}

conversejs/lib/plugins/livechat-specific/toolbar.ts

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 /**
  * Do some customization on the toolbar:
  * * change the appearance of the toggle occupants button

conversejs/lib/plugins/livechat-specific/utils.ts

@@ -25,7 +25,7 @@ export function getOpenPromise (): any {
       promise.isResolved = false
       promise.isPending = false
       promise.isRejected = true
-      throw (e)
+      throw (e as Error)
     }
   )
   return promise

conversejs/lib/plugins/livechat-viewer-mode.ts

@@ -22,11 +22,11 @@ export const livechatViewerModePlugin = {
       console.error('[livechatViewerModePlugin] getDefaultMUCNickname is not initialized.')
     } else {
       Object.assign(_converse.exports, {
-        getDefaultMUCNickname: function (this: any): any {
+        getDefaultMUCNickname: function (this: any, ...args: any[]): any {
           if (!_converse.api.settings.get('livechat_enable_viewer_mode')) {
-            return originalGetDefaultMUCNickname.apply(this, arguments)
+            return originalGetDefaultMUCNickname.apply(this, args)
           }
-          return originalGetDefaultMUCNickname.apply(this, arguments) ??
+          return originalGetDefaultMUCNickname.apply(this, args) ??
             getPreviousAnonymousNick() ??
             randomNick('Anonymous')
         }
@@ -72,8 +72,8 @@ export const livechatViewerModePlugin = {
       // Note: when previousNickname is set, model.get('nick') has not the nick yet...
       // It will only come after receiving a presence stanza.
       // So we use previousNickname before trying to read the model.
-      const nick = getPreviousAnonymousNick() ?? (model?.get ? model.get('nick') : '')
-      refreshViewerMode(nick && !/^Anonymous /.test(nick))
+      const nick = getPreviousAnonymousNick() ?? (model?.get ? model.get('nick') as string : '')
+      refreshViewerMode(!!nick && !/^Anonymous /.test(nick))
     })
   }
 }

conversejs/lib/plugins/slow-mode.ts

@@ -21,7 +21,13 @@ export const slowModePlugin = {
         return
       }
 
-      const slowModeDuration = parseInt(chatbox?.config?.get('slow_mode_duration'))
+      const slowModeDurationRaw = chatbox?.config?.get('slow_mode_duration') ?? NaN
+      const slowModeDuration =
+        typeof slowModeDurationRaw === 'string'
+          ? parseInt(slowModeDurationRaw)
+          : typeof slowModeDurationRaw === 'number'
+            ? Math.trunc(slowModeDurationRaw)
+            : NaN
       if (!(slowModeDuration > 0)) { // undefined, NaN, ...  are not considered > 0.
         return
       }

conversejs/lib/utils.ts

@@ -5,7 +5,7 @@
 function inIframe (): boolean {
   try {
     return window.self !== window.top
-  } catch (e) {
+  } catch (_err) {
     return true
   }
 }

eslint.config.mjs

@@ -6,6 +6,7 @@
 // * lint shared
 // * lint conversejs
 // * use eslint-plugin-lit
+// * delete old .eslintrc.json files
 
 import love from 'eslint-config-love'
 import eslint from '@eslint/js'
@@ -24,8 +25,7 @@ export default tseslint.config(
       'support/documentation', 'support',
       'build-*js',
 
-      'shared',
-      'conversejs'
+      'shared' // FIXME
     ]
   },
   eslint.configs.recommended,
@@ -55,7 +55,8 @@ export default tseslint.config(
     files: ['**/*.ts'],
     rules: {
       '@typescript-eslint/no-empty-function': ['error', { allow: ['arrowFunctions'] }],
-      '@typescript-eslint/no-unused-vars': [2, { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
+      'no-unused-vars': ['error', { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
       '@typescript-eslint/no-floating-promises': 'error',
       '@typescript-eslint/no-misused-promises': ['error', { checksVoidReturn: false }],
       '@typescript-eslint/no-var-requires': 'off',
@@ -83,8 +84,45 @@ export default tseslint.config(
           code: 120,
           comments: 120
         }
-      ],
-      'no-unused-vars': 'off'
+      ]
+    }
+  },
+  {
+    files: ['**/*.js'],
+    rules: {
+      // Disabling typescript-eslint rules for JS files (did not find a simplier way...)
+      '@typescript-eslint/no-empty-function': 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/no-floating-promises': 'off',
+      '@typescript-eslint/no-misused-promises': 'off',
+      '@typescript-eslint/no-var-requires': 'off',
+      '@typescript-eslint/strict-boolean-expressions': 'off',
+      '@typescript-eslint/return-await': 'off',
+      '@typescript-eslint/no-invalid-void-type': 'off',
+      '@typescript-eslint/triple-slash-reference': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/init-declarations': 'off',
+      '@typescript-eslint/consistent-type-imports': 'off',
+      '@typescript-eslint/consistent-type-exports': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/unbound-method': 'off',
+      '@typescript-eslint/prefer-promise-reject-errors': 'off',
+      '@typescript-eslint/max-params': 'off',
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/no-confusing-void-expression': 'off',
+      '@typescript-eslint/class-methods-use-this': 'off',
+      '@typescript-eslint/non-nullable-type-assertion-style': 'off',
+
+      'max-params': 'off',
+      'init-declarations': 'off',
+      'no-unused-vars': ['error', { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
+      'max-len': [
+        'error',
+        {
+          code: 120,
+          comments: 120
+        }
+      ]
     }
   },
   {
@@ -108,7 +146,7 @@ export default tseslint.config(
     }
   },
   {
-    files: ['shared/**/*.js', 'shared/**/*.ts'], // only ts?
+    files: ['shared/**/*.js', 'shared/**/*.ts'],
     languageOptions: {
       ecmaVersion: 6,
       globals: {
@@ -130,7 +168,7 @@ export default tseslint.config(
     }
   },
   {
-    files: ['client/**/*.js', 'client/**/*.ts'], // only ts?
+    files: ['client/**/*.js', 'client/**/*.ts', 'conversejs/**/*.js', 'conversejs/**/*.ts'],
     languageOptions: {
       ecmaVersion: 6,
       globals: {
@@ -139,7 +177,10 @@ export default tseslint.config(
       parser: typescriptParser,
       parserOptions: {
         ecmaVersion: 2018,
-        project: './client/tsconfig.json'
+        project: [
+          './client/tsconfig.json',
+          './conversejs/tsconfig.json'
+        ]
       }
     },
     // FIXME: not sure elintLit works.
@@ -149,5 +190,13 @@ export default tseslint.config(
     rules: {
       ...eslintLit.configs['flat/recommended'].rules
     }
+  },
+  {
+    files: ['conversejs/build-*.js', 'conversejs/loc.keys.js', 'conversejs/custom/webpack.livechat.js'],
+    languageOptions: {
+      globals: {
+        ...globals.node
+      }
+    }
   }
 )