matty/peertube-plugin-livechat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleaning FIXME and TODO

Browse Source
This commit is contained in:
John Livingston 2024-05-13 12:31:28 +02:00
parent 4e8a2b6720
commit e5ad7816b6
No known key found for this signature in database
GPG Key ID: B17B5640CE66CDBC
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
conversejs/custom/plugins/tasks/index.js
View File

@ -4,11 +4,11 @@ import { ChatRoomTaskList } from './task-list.js'
import { ChatRoomTasks } from './tasks.js' import { ChatRoomTasks } from './tasks.js'
import { getHeadingButtons, getMessageActionButtons, initOrDestroyChatRoomTaskLists } from './utils.js' import { getHeadingButtons, getMessageActionButtons, initOrDestroyChatRoomTaskLists } from './utils.js'
import { XMLNS_TASK, XMLNS_TASKLIST } from './constants.js' import { XMLNS_TASK, XMLNS_TASKLIST } from './constants.js'
import './components/muc-task-view.js' // FIXME: here or in another file? import './components/muc-task-view.js'
import './components/muc-task-list-view.js' // FIXME: here or in another file? import './components/muc-task-list-view.js'
import './components/muc-task-lists-view.js' // FIXME: here or in another file? import './components/muc-task-lists-view.js'
import './components/muc-task-app-view.js' // FIXME: here or in another file? import './components/muc-task-app-view.js'
import './modals/pick-task-list.js' // FIXME: here or in another file? import './modals/pick-task-list.js'
converse.plugins.add('livechat-converse-tasks', { converse.plugins.add('livechat-converse-tasks', {
dependencies: ['converse-muc', 'converse-disco', 'converse-pubsub'], dependencies: ['converse-muc', 'converse-disco', 'converse-pubsub'],

1
conversejs/custom/plugins/tasks/utils.js
View File

@ -114,7 +114,6 @@ function _destroyChatRoomTaskLists (mucModel) {
mucModel.taskManager.stop().catch(err => console.log(err)) mucModel.taskManager.stop().catch(err => console.log(err))
mucModel.taskManager = undefined mucModel.taskManager = undefined
// mucModel.tasklists.unload() FIXME: add a method to unregister from the pubsub, and empty the tasklist.
mucModel.tasklists = undefined mucModel.tasklists = undefined
mucModel.tasks = undefined mucModel.tasks = undefined

3
conversejs/custom/shared/lib/pubsub-manager.js
View File

@ -72,7 +72,7 @@ export class PubSubManager {
* Stops the manager * Stops the manager
*/ */
async stop () { async stop () {
// await this._unsubscribe() TODO // Note: no need to unsubscribe from the pubsub node, the backend will do when users leave the room.
if (this.stanzaHandler) { if (this.stanzaHandler) {
_converse.connection.deleteHandler(this.stanzaHandler) _converse.connection.deleteHandler(this.stanzaHandler)
@ -203,6 +203,7 @@ export class PubSubManager {
* *
* TODO: handle pagination if results are not all sent. * TODO: handle pagination if results are not all sent.
* See https://xmpp.org/extensions/xep-0060.html#subscriber-retrieve-returnsome * See https://xmpp.org/extensions/xep-0060.html#subscriber-retrieve-returnsome
* (seems Prosody does not handle pagination for now)
*/ */
async _retrieveAllItems () { async _retrieveAllItems () {
// Requesting all items. // Requesting all items.