eslint 8.57 WIP:

* tweaking rules
* fixing issues

eslint.config.mjs

@@ -2,23 +2,30 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME:
+// * lint shared
+// * lint conversejs
+// * use eslint-plugin-lit
+
 import love from 'eslint-config-love'
 import eslint from '@eslint/js'
 import tseslint from 'typescript-eslint'
 import typescriptParser from '@typescript-eslint/parser'
 import stylistic from '@stylistic/eslint-plugin'
+import eslintLit from 'eslint-plugin-lit'
 import globals from 'globals'
 
 export default tseslint.config(
   {
     ignores: [
-      "node_modules/", "dist/", "webpack.config.js",
-      "build/",
-      "vendor/",
-      "support/documentation", "support",
-      "build-*js",
+      'node_modules/', 'dist/', 'webpack.config.js',
+      'build/',
+      'vendor/',
+      'support/documentation', 'support',
+      'build-*js',
 
-      "shared", "client", "conversejs"
+      'shared',
+      'conversejs'
     ]
   },
   eslint.configs.recommended,
@@ -27,48 +34,57 @@ export default tseslint.config(
     ...love,
     files: ['**/*.ts']
   },
+  stylistic.configs.customize({
+    quotes: 'single',
+    semi: false,
+    commaDangle: 'never',
+    blockSpacing: true,
+    braceStyle: '1tbs',
+    indent: 2,
+    quoteProps: 'as-needed'
+  }),
   {
-    plugins: {
-      '@stylistic': stylistic
-    },
     rules: {
-      "@stylistic/semi": ["error", "never"]
+      '@stylistic/space-before-function-paren': ['error', { anonymous: 'always', asyncArrow: 'always', named: 'always' }],
+      '@stylistic/arrow-parens': 'off',
+      '@stylistic/operator-linebreak': ['error', 'after', { overrides: { '?': 'before', ':': 'before' } }],
+      '@stylistic/max-statements-per-line': ['error', { max: 2 }]
     }
   },
   {
     files: ['**/*.ts'],
     rules: {
-      "@typescript-eslint/no-empty-function": ["error", {"allow": ["arrowFunctions"]}],
-      "@typescript-eslint/no-unused-vars": [2, {"argsIgnorePattern": "^_", "caughtErrorsIgnorePattern": "^_"}],
-      "@typescript-eslint/no-floating-promises": "error",
-      "@typescript-eslint/no-misused-promises": "error",
-      "@typescript-eslint/no-var-requires": "off",
-      "@typescript-eslint/strict-boolean-expressions": "off",
-      "@typescript-eslint/return-await": [2, "in-try-catch"], // FIXME: correct?
-      "@typescript-eslint/no-invalid-void-type": "off",
-      "@typescript-eslint/triple-slash-reference": "off",
-      "@typescript-eslint/no-explicit-any": "off", // FIXME: should be "error", and we should use 'unknown' in the code.
-      "init-declarations": "off",
-      "@typescript-eslint/init-declarations": "off",
-      "@typescript-eslint/consistent-type-imports": "off",
-      "@typescript-eslint/consistent-type-exports": "off",
-      "@typescript-eslint/no-require-imports": "off",
-      "@typescript-eslint/unbound-method": "off",
-      "@typescript-eslint/prefer-promise-reject-errors": "off",
-      "max-params": "off",
-      "@typescript-eslint/max-params": ["error", { "max": 8 }], // FIXME: this rules should use the default max value.
-      "@typescript-eslint/explicit-function-return-type": "error",
-      "@typescript-eslint/no-confusing-void-expression": "off",
-      "@typescript-eslint/class-methods-use-this": "off",
-      "@typescript-eslint/non-nullable-type-assertion-style": "off",
-      "max-len": [
-        "error",
+      '@typescript-eslint/no-empty-function': ['error', { allow: ['arrowFunctions'] }],
+      '@typescript-eslint/no-unused-vars': [2, { argsIgnorePattern: '^_', caughtErrorsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-floating-promises': 'error',
+      '@typescript-eslint/no-misused-promises': ['error', { checksVoidReturn: false }],
+      '@typescript-eslint/no-var-requires': 'off',
+      '@typescript-eslint/strict-boolean-expressions': 'off',
+      '@typescript-eslint/return-await': [2, 'in-try-catch'], // FIXME: correct?
+      '@typescript-eslint/no-invalid-void-type': 'off',
+      '@typescript-eslint/triple-slash-reference': 'off',
+      '@typescript-eslint/no-explicit-any': 'off', // FIXME: should be "error", and we should use 'unknown' in the code.
+      'init-declarations': 'off',
+      '@typescript-eslint/init-declarations': 'off',
+      '@typescript-eslint/consistent-type-imports': 'off',
+      '@typescript-eslint/consistent-type-exports': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/unbound-method': 'off',
+      '@typescript-eslint/prefer-promise-reject-errors': 'off',
+      'max-params': 'off',
+      '@typescript-eslint/max-params': ['error', { max: 8 }], // FIXME: this rules should use the default max value.
+      '@typescript-eslint/explicit-function-return-type': 'error',
+      '@typescript-eslint/no-confusing-void-expression': 'off',
+      '@typescript-eslint/class-methods-use-this': 'off',
+      '@typescript-eslint/non-nullable-type-assertion-style': 'off',
+      'max-len': [
+        'error',
         {
-          "code": 120,
-          "comments": 120
+          code: 120,
+          comments: 120
         }
       ],
-      "no-unused-vars": "off"
+      'no-unused-vars': 'off'
     }
   },
   {
@@ -90,5 +106,48 @@ export default tseslint.config(
         project: './server/tsconfig.json'
       }
     }
+  },
+  {
+    files: ['shared/**/*.js', 'shared/**/*.ts'], // only ts?
+    languageOptions: {
+      ecmaVersion: 6,
+      globals: {
+        ...globals.es2016,
+        ...globals.browser
+      },
+      parser: typescriptParser,
+      parserOptions: {
+        ecmaVersion: 2018,
+        project: [
+          './server/tsconfig.json',
+          './client/tsconfig.json'
+        ],
+        projectService: {
+          allowDefaultProject: 'shared/**/*.ts',
+          defaultProject: './server/tsconfig.json'
+        }
+      }
+    }
+  },
+  {
+    files: ['client/**/*.js', 'client/**/*.ts'], // only ts?
+    languageOptions: {
+      ecmaVersion: 6,
+      globals: {
+        ...globals.browser
+      },
+      parser: typescriptParser,
+      parserOptions: {
+        ecmaVersion: 2018,
+        project: './client/tsconfig.json'
+      }
+    },
+    // FIXME: not sure elintLit works.
+    plugins: {
+      ...eslintLit.configs['flat/recommended'].plugins
+    },
+    rules: {
+      ...eslintLit.configs['flat/recommended'].rules
+    }
   }
 )