eslint 8.57 WIP:

* tweaking rules
* fixing issues

client/common/configuration/elements/channel-configuration.ts

@@ -32,7 +32,7 @@ export class ChannelConfigurationElement extends LivechatElement {
   public validationError?: ValidationError
 
   @state()
-  public actionDisabled: boolean = false
+  public actionDisabled = false
 
   private _asyncTaskRender: Task
 
@@ -113,7 +113,7 @@ export class ChannelConfigurationElement extends LivechatElement {
     }
   }
 
-  public readonly getInputValidationClass = (propertyName: string): { [key: string]: boolean } => {
+  public readonly getInputValidationClass = (propertyName: string): Record<string, boolean> => {
     const validationErrorTypes: ValidationErrorType[] | undefined =
       this.validationError?.properties[`${propertyName}`]
     return validationErrorTypes ? (validationErrorTypes.length ? { 'is-invalid': true } : { 'is-valid': true }) : {}

client/common/configuration/elements/channel-emojis.ts

@@ -30,7 +30,7 @@ export class ChannelEmojisElement extends LivechatElement {
   public validationError?: ValidationError
 
   @state()
-  public actionDisabled: boolean = false
+  public actionDisabled = false
 
   private _asyncTaskRender: Task
 
@@ -192,7 +192,7 @@ export class ChannelEmojisElement extends LivechatElement {
           throw new Error('Invalid data')
         }
 
-        const url = await this._convertImageToDataUrl(entry.url)
+        const url = await this._convertImageToDataUrl(entry.url as string)
         const sn = entry.sn as string
 
         const item: ChannelEmojisConfiguration['emojis']['customEmojis'][0] = {
@@ -211,7 +211,7 @@ export class ChannelEmojisElement extends LivechatElement {
         await this.ptTranslate(LOC_ACTION_IMPORT_EMOJIS_INFO)
       )
     } catch (err: any) {
-      this.ptNotifier.error(err.toString(), await this.ptTranslate(LOC_ERROR))
+      this.ptNotifier.error((err as Error).toString(), await this.ptTranslate(LOC_ERROR))
     } finally {
       this.actionDisabled = false
     }
@@ -250,7 +250,7 @@ export class ChannelEmojisElement extends LivechatElement {
       a.remove()
     } catch (err: any) {
       this.logger.error(err)
-      this.ptNotifier.error(err.toString())
+      this.ptNotifier.error((err as Error).toString())
     } finally {
       this.actionDisabled = false
     }

client/common/configuration/elements/channel-home.ts

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { html } from 'lit'
 import { customElement, state } from 'lit/decorators.js'
 import { ptTr } from '../../lib/directives/translation'

client/common/configuration/elements/channel-tabs.ts

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import { LivechatElement } from '../../lib/elements/livechat'
 import { ptTr } from '../../lib/directives/translation'
 import { html, TemplateResult } from 'lit'

client/common/configuration/elements/templates/channel-configuration.ts

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import type { ChannelConfigurationElement } from '../channel-configuration'
 import type { DynamicFormHeader, DynamicFormSchema } from '../../../lib/elements/dynamic-table-form'
 import { ptTr } from '../../../lib/directives/translation'
@@ -9,7 +12,7 @@ import { html, TemplateResult } from 'lit'
 import { classMap } from 'lit/directives/class-map.js'
 
 export function tplChannelConfiguration (el: ChannelConfigurationElement): TemplateResult {
-  const tableHeaderList: {[key: string]: DynamicFormHeader} = {
+  const tableHeaderList: Record<string, DynamicFormHeader> = {
     forbiddenWords: {
       entries: {
         colName: ptTr(LOC_LIVECHAT_CONFIGURATION_CHANNEL_FORBIDDEN_WORDS_LABEL),
@@ -57,7 +60,7 @@ export function tplChannelConfiguration (el: ChannelConfigurationElement): Templ
       }
     }
   }
-  const tableSchema: {[key: string]: DynamicFormSchema} = {
+  const tableSchema: Record<string, DynamicFormSchema> = {
     forbiddenWords: {
       entries: {
         inputType: 'tags',

client/common/configuration/elements/templates/channel-emojis.ts

@@ -2,6 +2,9 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
+// FIXME: @stylistic/indent is buggy with strings literrals.
+/* eslint-disable @stylistic/indent */
+
 import type { ChannelEmojisElement } from '../channel-emojis'
 import type { DynamicFormHeader, DynamicFormSchema } from '../../../lib/elements/dynamic-table-form'
 import { maxEmojisPerChannel } from 'shared/lib/emojis'

client/common/configuration/services/channel-details.ts

@@ -162,7 +162,8 @@ export class ChannelDetailsService {
     }
 
     for (const channel of channels.data) {
-      channel.livechatConfigurationUri = '/p/livechat/configuration/channel?channelId=' + encodeURIComponent(channel.id)
+      channel.livechatConfigurationUri =
+        '/p/livechat/configuration/channel?channelId=' + encodeURIComponent(channel.id as string | number)
 
       // Note: since Peertube v6.0.0, channel.avatar is dropped, and we have to use channel.avatars.
       // So, if !channel.avatar, we will search a suitable one in channel.avatars, and fill channel.avatar.
@@ -196,10 +197,11 @@ export class ChannelDetailsService {
   }
 
   public async fetchEmojisConfiguration (channelId: number): Promise<ChannelEmojisConfiguration> {
+    const url = getBaseRoute(this._registerClientOptions) +
+      '/api/configuration/channel/emojis/' +
+      encodeURIComponent(channelId)
     const response = await fetch(
-      getBaseRoute(this._registerClientOptions) +
-        '/api/configuration/channel/emojis/' +
-        encodeURIComponent(channelId),
+      url,
       {
         method: 'GET',
         headers: this._headers
@@ -311,10 +313,11 @@ export class ChannelDetailsService {
     channelId: number,
     channelEmojis: ChannelEmojis
   ): Promise<ChannelEmojisConfiguration> {
+    const url = getBaseRoute(this._registerClientOptions) +
+      '/api/configuration/channel/emojis/' +
+      encodeURIComponent(channelId)
     const response = await fetch(
-      getBaseRoute(this._registerClientOptions) +
-        '/api/configuration/channel/emojis/' +
-        encodeURIComponent(channelId),
+      url,
       {
         method: 'POST',
         headers: this._headers,
@@ -330,11 +333,12 @@ export class ChannelDetailsService {
   }
 
   public async enableEmojisOnlyModeOnAllRooms (channelId: number): Promise<void> {
+    const url = getBaseRoute(this._registerClientOptions) +
+      '/api/configuration/channel/emojis/' +
+      encodeURIComponent(channelId) +
+      '/enable_emoji_only'
     const response = await fetch(
-      getBaseRoute(this._registerClientOptions) +
-        '/api/configuration/channel/emojis/' +
-        encodeURIComponent(channelId) +
-        '/enable_emoji_only',
+      url,
       {
         method: 'POST',
         headers: this._headers