Better typing.

server/lib/routers/index.ts

@@ -1,24 +1,15 @@
 import type { NextFunction, Request, Response } from 'express'
 import { initWebchatRouter } from './webchat'
 
-type InitRoutersOptions = Pick<RegisterServerOptions, 'settingsManager' | 'getRouter' | 'peertubeHelpers'>
+async function initRouters (options: RegisterServerOptions): Promise<void> {
+  const { getRouter } = options
 
-async function initRouters ({
-  settingsManager,
-  getRouter,
-  peertubeHelpers
-}: InitRoutersOptions): Promise<void> {
   const router = getRouter()
   router.get('/ping', (req: Request, res: Response, _next: NextFunction) => res.json({ message: 'pong' }))
 
-  router.use('/webchat', await initWebchatRouter({
+  router.use('/webchat', await initWebchatRouter(options))
-    getRouter,
-    peertubeHelpers,
-    settingsManager
-  }))
 }
 
 export {
-  InitRoutersOptions,
   initRouters
 }

server/lib/routers/webchat.ts

@@ -1,4 +1,3 @@
-import type { InitRoutersOptions } from './index'
 import type { Router, Request, Response, NextFunction } from 'express'
 import * as path from 'path'
 const fs = require('fs').promises
@@ -7,7 +6,7 @@ async function initWebchatRouter ({
   getRouter,
   peertubeHelpers,
   settingsManager
-}: InitRoutersOptions): Promise<Router> {
+}: RegisterServerOptions): Promise<Router> {
   const converseJSIndex = await fs.readFile(path.resolve(__dirname, '../../conversejs/index.html'))
 
   const router = getRouter()

server/main.ts

@@ -5,20 +5,13 @@ import decache from 'decache'
 
 let logger: Logger | undefined
 
-async function register ({
+async function register (options: RegisterServerOptions): Promise<any> {
-  registerSetting,
+  const { peertubeHelpers } = options
-  settingsManager,
+
-  getRouter,
-  peertubeHelpers
-}: RegisterServerOptions): Promise<any> {
   logger = peertubeHelpers.logger
 
-  await initSettings({ registerSetting })
+  await initSettings(options)
-  await initRouters({
+  await initRouters(options)
-    settingsManager,
-    getRouter,
-    peertubeHelpers
-  })
 }
 
 async function unregister (): Promise<any> {