Typescript v5 + eslint 8.57 WIP

This commit also improves some type handling in the project.

server/lib/diagnostic/prosody.ts

@@ -235,7 +235,7 @@ export async function diagProsody (test: string, options: RegisterServerOptions)
       title: 'Prosody error log (last 50 lines)',
       message: logLines.join('\n')
     })
-  } catch (error) {
+  } catch (_err) {
     // Error should be because file does not exists. This is not an error case, just ignoring.
   }
 

server/lib/diagnostic/utils.ts

@@ -28,7 +28,7 @@ export interface TestResult {
 
 export function newResult (test: string): TestResult {
   return {
-    test: test,
+    test,
     ok: false,
     messages: [],
     debug: [],

server/lib/diagnostic/video.ts

@@ -26,7 +26,7 @@ export async function diagVideo (test: string, { settingsManager }: RegisterServ
     result.messages.push('Displaying «open in new window» button')
   }
 
-  let atLeastOne: boolean = false
+  let atLeastOne = false
   if (videoSettings['chat-per-live-video']) {
     result.messages.push('Chat can be enabled on live videos.')
     atLeastOne = true