diff --git a/server/lib/diagnostic/backend.ts b/server/lib/diagnostic/backend.ts index 15af4b83..aa9bf004 100644 --- a/server/lib/diagnostic/backend.ts +++ b/server/lib/diagnostic/backend.ts @@ -1,6 +1,6 @@ import { newResult, TestResult } from './utils' -export async function diagBackend (test: string, _settingsManager: PluginSettingsManager): Promise { +export async function diagBackend (test: string, _options: RegisterServerOptions): Promise { const result = newResult(test) result.label = 'Backend connection' result.ok = true diff --git a/server/lib/diagnostic/chat-type.ts b/server/lib/diagnostic/chat-type.ts index 0e41230e..6ef6b7ef 100644 --- a/server/lib/diagnostic/chat-type.ts +++ b/server/lib/diagnostic/chat-type.ts @@ -1,6 +1,6 @@ import { newResult, TestResult } from './utils' -export async function diagChatType (test: string, settingsManager: PluginSettingsManager): Promise { +export async function diagChatType (test: string, { settingsManager }: RegisterServerOptions): Promise { const result = newResult(test) const typeSettings = await settingsManager.getSettings([ 'chat-use-prosody', diff --git a/server/lib/diagnostic/converse.ts b/server/lib/diagnostic/converse.ts index 8453af3a..41da1f92 100644 --- a/server/lib/diagnostic/converse.ts +++ b/server/lib/diagnostic/converse.ts @@ -1,6 +1,6 @@ import { newResult, TestResult } from './utils' -export async function diagConverse (test: string, settingsManager: PluginSettingsManager): Promise { +export async function diagConverse (test: string, { settingsManager }: RegisterServerOptions): Promise { const result = newResult(test) result.label = 'Builtin ConverseJS on XMPP service' const builtinSettings = await settingsManager.getSettings([ diff --git a/server/lib/diagnostic/index.ts b/server/lib/diagnostic/index.ts index dbb5c7b9..d6bbbf7e 100644 --- a/server/lib/diagnostic/index.ts +++ b/server/lib/diagnostic/index.ts @@ -6,21 +6,21 @@ import { diagProsody } from './prosody' import { diagUri } from './uri' import { diagVideo } from './video' -export async function diag (test: string, settingsManager: PluginSettingsManager): Promise { +export async function diag (test: string, options: RegisterServerOptions): Promise { let result: TestResult if (test === 'backend') { - result = await diagBackend(test, settingsManager) + result = await diagBackend(test, options) } else if (test === 'webchat-video') { - result = await diagVideo(test, settingsManager) + result = await diagVideo(test, options) } else if (test === 'webchat-type') { - result = await diagChatType(test, settingsManager) + result = await diagChatType(test, options) } else if (test === 'prosody') { - result = await diagProsody(test, settingsManager) + result = await diagProsody(test, options) } else if (test === 'converse') { - result = await diagConverse(test, settingsManager) + result = await diagConverse(test, options) } else if (test === 'use-uri') { - result = await diagUri(test, settingsManager) + result = await diagUri(test, options) } else { result = newResult(test) result.messages.push('Unknown test') diff --git a/server/lib/diagnostic/prosody.ts b/server/lib/diagnostic/prosody.ts index b6bbfa3d..5f56a3ff 100644 --- a/server/lib/diagnostic/prosody.ts +++ b/server/lib/diagnostic/prosody.ts @@ -1,9 +1,7 @@ import { newResult, TestResult } from './utils' -export async function diagProsody (test: string, _settingsManager: PluginSettingsManager): Promise { +export async function diagProsody (test: string, _options: RegisterServerOptions): Promise { const result = newResult(test) - result.ok = false result.label = 'Builtin Prosody and ConverseJS' - result.messages.push('Not Implemented Yet') return result } diff --git a/server/lib/diagnostic/uri.ts b/server/lib/diagnostic/uri.ts index f0ccc7f9..c57728d7 100644 --- a/server/lib/diagnostic/uri.ts +++ b/server/lib/diagnostic/uri.ts @@ -1,6 +1,6 @@ import { newResult, TestResult } from './utils' -export async function diagUri (test: string, settingsManager: PluginSettingsManager): Promise { +export async function diagUri (test: string, { settingsManager }: RegisterServerOptions): Promise { const result = newResult(test) result.label = 'External Webchat using an iframe' const settings = await settingsManager.getSettings([ diff --git a/server/lib/diagnostic/video.ts b/server/lib/diagnostic/video.ts index 4a5a0882..b14a4194 100644 --- a/server/lib/diagnostic/video.ts +++ b/server/lib/diagnostic/video.ts @@ -1,6 +1,6 @@ import { newResult, TestResult } from './utils' -export async function diagVideo (test: string, settingsManager: PluginSettingsManager): Promise { +export async function diagVideo (test: string, { settingsManager }: RegisterServerOptions): Promise { const result = newResult(test) result.label = 'Webchat activated on videos' const videoSettings = await settingsManager.getSettings([ diff --git a/server/lib/routers/settings.ts b/server/lib/routers/settings.ts index e58e852a..3b49d4ed 100644 --- a/server/lib/routers/settings.ts +++ b/server/lib/routers/settings.ts @@ -2,11 +2,8 @@ import type { Router, Request, Response, NextFunction } from 'express' import { diag } from '../diagnostic' import { getBaseStaticRoute, isUserAdmin } from '../helpers' -async function initSettingsRouter ({ - peertubeHelpers, - getRouter, - settingsManager -}: RegisterServerOptions): Promise { +async function initSettingsRouter (options: RegisterServerOptions): Promise { + const { peertubeHelpers, getRouter } = options const router = getRouter() const logger = peertubeHelpers.logger @@ -34,7 +31,7 @@ async function initSettingsRouter ({ const test: string = req.body.test || '' logger.info('Accessing peertube-plugin-livechat diagnostic tool, test "' + test + '".') - const result = await diag(test, settingsManager) + const result = await diag(test, options) res.status(200) res.json(result)