From 724e8fdce982ebf6dba51ae56cac6a0c87ae3f17 Mon Sep 17 00:00:00 2001
From: John Livingston <git@john-livingston.fr>
Date: Wed, 12 Jun 2024 18:59:34 +0200
Subject: [PATCH] Fix lit linting: input-tags should only handle text, not
 numbers.

---
 .../common/lib/elements/dynamic-table-form.ts |  1 -
 client/common/lib/elements/tags-input.ts      | 25 ++++++++-----------
 2 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/client/common/lib/elements/dynamic-table-form.ts b/client/common/lib/elements/dynamic-table-form.ts
index b7999124..376ec8ff 100644
--- a/client/common/lib/elements/dynamic-table-form.ts
+++ b/client/common/lib/elements/dynamic-table-form.ts
@@ -553,7 +553,6 @@ export class DynamicTableFormElement extends LivechatElement {
     propertyValue: Array<string | number>,
     originalIndex: number): TemplateResult => {
     return html`<livechat-tags-input
-      .type=${'text'}
       .name=${inputName}
       class=${classMap(
         Object.assign(
diff --git a/client/common/lib/elements/tags-input.ts b/client/common/lib/elements/tags-input.ts
index 84d6291b..a0e783a4 100644
--- a/client/common/lib/elements/tags-input.ts
+++ b/client/common/lib/elements/tags-input.ts
@@ -12,23 +12,20 @@ import { repeat } from 'lit/directives/repeat.js'
 
 @customElement('livechat-tags-input')
 export class TagsInputElement extends LivechatElement {
-  @property({ attribute: false })
-  public type?: string = 'text'
-
   @property({ attribute: false })
   public name?: string
 
   @property({ attribute: false })
-  public min?: string
+  public min?: number
 
   @property({ attribute: false })
-  public max?: string
+  public max?: number
 
   @property({ attribute: false })
-  public maxlength?: string
+  public maxlength?: number
 
   @property({ attribute: false })
-  public minlength?: string
+  public minlength?: number
 
   @state()
   private _inputValue?: string = ''
@@ -37,10 +34,10 @@ export class TagsInputElement extends LivechatElement {
   public inputPlaceholder?: string = ''
 
   @property({ attribute: false })
-  public datalist?: Array<string | number>
+  public datalist?: string[]
 
-  @property({ reflect: true })
-  public value: Array<string | number> = []
+  @property({ reflect: true, type: Array })
+  public value: string[] = []
 
   @state()
   private _searchedTagsIndex: number[] = []
@@ -113,7 +110,7 @@ export class TagsInputElement extends LivechatElement {
           )}
         </ul>
         <input
-        type=${ifDefined(this.type)}
+        type="text"
         name=${ifDefined(this.name)}
         id="${this.id ?? 'tags-input'}-input"
         list="${this.id ?? 'tags-input'}-input-datalist"
@@ -126,8 +123,8 @@ export class TagsInputElement extends LivechatElement {
         @keyup=${(e: KeyboardEvent) => this._handleKeyUp(e)}
         @input=${(e: InputEvent) => this._handleInputEvent(e)}
         @change=${(e: Event) => e.stopPropagation()}
-        .value=${this._inputValue}
-        .placeholder=${this.inputPlaceholder} />
+        .value=${this._inputValue ?? ''}
+        placeholder=${ifDefined(this.inputPlaceholder)} />
         ${(this.datalist)
           ? html`<datalist id="${this.id ?? 'tags-input'}-datalist">
             ${(this.datalist ?? []).map((value) => html`<option value=${value}>`)}
@@ -296,7 +293,7 @@ export class TagsInputElement extends LivechatElement {
 
     if (inputValue?.length) {
       for (const [i, tag] of this.value.entries()) {
-        if ((tag as string).toLowerCase().includes(inputValue.toLowerCase())) {
+        if (tag.toLowerCase().includes(inputValue.toLowerCase())) {
           searchedTags.push(i)
         }
       }