From 5ef429e9f2a83ed824d01617b9e14b110bdef355 Mon Sep 17 00:00:00 2001
From: Mehdi Benadel <mehdi.benadel@gmail.com>
Date: Thu, 23 May 2024 18:38:07 +0200
Subject: [PATCH] update css handling on dynamic table form

---
 assets/styles/configuration.scss              | 38 ++++++++++++++
 .../common/lib/elements/dynamic-table-form.ts | 52 ++-----------------
 2 files changed, 43 insertions(+), 47 deletions(-)

diff --git a/assets/styles/configuration.scss b/assets/styles/configuration.scss
index affd7648..3b523a0f 100644
--- a/assets/styles/configuration.scss
+++ b/assets/styles/configuration.scss
@@ -209,3 +209,41 @@ $small-view: 800px;
     }
   }
 }
+
+livechat-dynamic-table-form {
+  table {
+    table-layout: fixed;
+    text-align: center;
+
+    tr {
+      border: 1px var(--greyBackgroundColor) solid;
+    }
+
+    td,
+    th {
+      word-wrap: break-word;
+      vertical-align: top;
+      padding: 5px 7px;
+    }
+
+    td:last-child {
+      vertical-align: middle;
+    }
+
+    tbody tr:nth-child(odd) {
+      background-color: var(--greySecondaryBackgroundColor);
+    }
+  }
+
+  button {
+    padding: 2px !important;
+  }
+
+  .dynamic-table-add-row {
+    background-color: var(--bs-green);
+  }
+
+  .dynamic-table-remove-row {
+    background-color: var(--bs-orange);
+  }
+}
diff --git a/client/common/lib/elements/dynamic-table-form.ts b/client/common/lib/elements/dynamic-table-form.ts
index 1a6b4010..05435ba0 100644
--- a/client/common/lib/elements/dynamic-table-form.ts
+++ b/client/common/lib/elements/dynamic-table-form.ts
@@ -2,11 +2,12 @@
 //
 // SPDX-License-Identifier: AGPL-3.0-only
 
-import { css, html, LitElement, nothing, TemplateResult } from 'lit'
+import { html, nothing, TemplateResult } from 'lit'
 import { repeat } from 'lit/directives/repeat.js'
 import { customElement, property, state } from 'lit/decorators.js'
 import { ifDefined } from 'lit/directives/if-defined.js'
 import { unsafeHTML } from 'lit/directives/unsafe-html.js'
+import { LivechatElement } from './livechat'
 
   // This content comes from the file assets/images/plus-square.svg, from the Feather icons set https://feathericons.com/
 const AddSVG: string =
@@ -61,8 +62,7 @@ interface CellDataSchema {
 }
 
 @customElement('livechat-dynamic-table-form')
-// FIXME: use LivechatElement instead of LitElement? If so, be carefull about createRenderRoot
-export class DynamicTableFormElement extends LitElement {
+export class DynamicTableFormElement extends LivechatElement {
 
   @property({ attribute: false })
   public header: { [key: string]: { colName: TemplateResult, description: TemplateResult } } = {}
@@ -86,48 +86,6 @@ export class DynamicTableFormElement extends LitElement {
   @property({ attribute: false })
   private _colOrder: string[] = []
 
-  static styles = css`
-      table {
-        table-layout: fixed;
-        text-align: center;
-      }
-
-      table td, table th {
-        word-wrap:break-word;
-        vertical-align: top;
-        padding: 5px 7px;
-      }
-
-      table tbody > :nth-child(odd) {
-        background-color: var(--greySecondaryBackgroundColor);
-      }
-
-      button {
-        padding: 2px;
-      }
-
-      .dynamic-table-add-row {
-        background-color: var(--bs-green);
-      }
-
-      .dynamic-table-remove-row {
-        background-color: var(--bs-orange);
-      }
-  `;
-
-  protected createRenderRoot = () => {
-    if (document.head.querySelector(`style[data-tagname="${this.tagName}"]`)) {
-      return this;
-    }
-
-    const style = document.createElement("style");
-    style.innerHTML = DynamicTableFormElement.styles.toString();
-    style.setAttribute("data-tagname", this.tagName);
-    document.head.append(style);
-
-    return this
-  }
-
   // fixes situations when list has been reinitialized or changed outside of CustomElement
   private _updateLastRowId = () => {
     for (let rowById of this._rowsById) {
@@ -211,7 +169,7 @@ export class DynamicTableFormElement extends LitElement {
       ${Object.entries(rowData.row).filter(([k, v]) => k != '_id')
                                    .sort(([k1,_1], [k2,_2]) => this._colOrder.indexOf(k1) - this._colOrder.indexOf(k2))
                                    .map((data) => this.renderDataCell(data, rowData._id))}
-      <td class="form-group"><button type="button" class="peertube-button-link dynamic-table-remove-row" @click=${() => this._removeRow(rowData._id)}>${unsafeHTML(RemoveSVG)}</button></td>
+      <td class="form-group"><button type="button" class="peertube-button-link orange-button dynamic-table-remove-row" @click=${() => this._removeRow(rowData._id)}>${unsafeHTML(RemoveSVG)}</button></td>
     </tr>`
 
   }
@@ -220,7 +178,7 @@ export class DynamicTableFormElement extends LitElement {
     return html`<tfoot>
     <tr>
       ${Object.values(this.header).map(() => html`<td></td>`)}
-      <td><button type="button" class="peertube-button-link dynamic-table-add-row" @click=${this._addRow}>${unsafeHTML(AddSVG)}</button></td>
+      <td><button type="button" class="peertube-button-link orange-button dynamic-table-add-row" @click=${this._addRow}>${unsafeHTML(AddSVG)}</button></td>
     </tr>
   </tfoot>`
   }