From 4840bd735a016efa4987a0ee2c2c4754b84041ca Mon Sep 17 00:00:00 2001
From: John Livingston <git@john-livingston.fr>
Date: Fri, 7 May 2021 19:18:41 +0200
Subject: [PATCH] Better default values for settings:

* Remove old Peertube 3.0.1 compatibility (default value for checkbox settings should be false)
---
 CHANGELOG.md           |  2 ++
 server/lib/settings.ts | 12 ++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3e93f832..537ffe51 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,10 +5,12 @@
 ### Features
 
 * Don't display webchat when viewing a playlist.
+* Better default values for settings.
 
 ### Fixes
 
 * Fix: starting with Peertube 3.2.0, there is a header 'X-Frame-Options'. Removing it on the iframe route.
+* Remove old Peertube 3.0.1 compatibility (default value for checkbox settings should be false)
 
 ## v2.1.3
 
diff --git a/server/lib/settings.ts b/server/lib/settings.ts
index cfeefb45..4af71794 100644
--- a/server/lib/settings.ts
+++ b/server/lib/settings.ts
@@ -56,7 +56,7 @@ Before asking for help, please use this diagnostic tool:
     name: 'chat-auto-display',
     label: 'Automatically open the chat',
     type: 'input-checkbox',
-    default: false,
+    default: true,
     private: false
   })
   registerSetting({
@@ -64,20 +64,20 @@ Before asking for help, please use this diagnostic tool:
     label: 'Show the «open in new window» button',
     private: false,
     type: 'input-checkbox',
-    default: false
+    default: true
   })
   registerSetting({
     name: 'chat-only-locals',
     label: 'Chats are only available for local videos.',
     type: 'input-checkbox',
-    default: false, // TODO: set to true when peertube has fixed https://github.com/Chocobozzz/PeerTube/issues/3838
+    default: true,
     private: false
   })
   registerSetting({
     name: 'chat-all-lives',
     label: 'Activate chat for all lives',
     type: 'input-checkbox',
-    default: false,
+    default: true,
     descriptionHTML: 'If checked, a chat will be added to all lives.',
     private: false
   })
@@ -106,7 +106,7 @@ Before asking for help, please use this diagnostic tool:
     label: 'Use builtin Prosody XMPP Server',
     type: 'input-checkbox',
     // /!\ dont auto-activate on existing settups. FIXME: how to do this?
-    default: false, // TODO: set to true when peertube has fixed https://github.com/Chocobozzz/PeerTube/issues/3838
+    default: false, // TODO: set to true when we have a way to know if the plugin was previously installed.
     private: false,
     descriptionHTML: 'If checked, this will use a builtin XMPP server. This is the recommanded setup.'
   })
@@ -126,7 +126,7 @@ Before asking for help, please use this diagnostic tool:
     name: 'chat-use-builtin',
     label: 'Use builtin ConverseJS',
     type: 'input-checkbox',
-    default: false, // TODO: set to true when peertube has fixed https://github.com/Chocobozzz/PeerTube/issues/3838
+    default: false,
     private: false,
     descriptionHTML: 'If checked, use a builtin ConverseJS iframe.<br>' +
     'You still have to configure an external XMPP service. Please see the ' +