Reverting usage of RE2 (WIP):

**Breaking changes**

The livechat v13 introduced a new library to handle regular expressions in forbidden words, to avoid
[ReDOS](https://en.wikipedia.org/wiki/ReDoS) attacks.
Unfortunately, this library was not able to install itself properly on some systems, and some admins were not able
to install the livechat plugin.

That's why we have disabled this library in v14, and introduce a new settings to enable regexp in forbidden words.
By default this settings is disabled, and your users won't be able to use regexp in their forbidden words.

The risk by enabling this feature is that a malicious user could cause a denial of service for the chat bot, by using a
special crafted regular expression in their channel options, and sending a special crafter message in one of their
rooms. If you trust your users (those who have rights to livestream), you can enable the settings. Otherwise it is not
recommanded. See the documentation for more informations.

**Minor changes and fixes**

* Channel's forbidden words: new "enable" column.
* New settings to enable regular expressions for channel forbidden words.
* "Channel advanced configuration" settings: removing the "experimental feature" label.
This commit is contained in:
John Livingston
2025-06-19 12:07:39 +02:00
parent e41529b61f
commit 3624dd5c3c
65 changed files with 343 additions and 2145 deletions

View File

@ -55,6 +55,10 @@ users will be able to add some customization on their channels, activate the mod
If you encounter any issue with this feature, you can disable it.
### {{% livechat_label enable_users_regexp %}}
{{% livechat_label enable_users_regexp_description %}}
## Chat behaviour
### {{% livechat_label room_type_label %}}

View File

@ -47,9 +47,7 @@ You can [open an issue](https://github.com/JohnXLivingston/peertube-plugin-livec
By checking this option, each line of the "{{% livechat_label livechat_configuration_channel_forbidden_words_label %}}" field will be considered as a [regular expression](https://en.wikipedia.org/wiki/Regular_expression).
Please note that not all regular expression are accepted.
Under the hood, we are using the [node-re2](https://github.com/uhop/node-re2) library.
Please check [node-re2](https://github.com/uhop/node-re2) and [RE2 documentation](https://github.com/google/re2/wiki/Syntax) for more information about the accepted syntax and the limitations.
This feature is optional and can be disabled by admins.
## {{% livechat_label livechat_configuration_applytomoderators_label %}}