From 33be9b3fc597f245aab09897a126168dea52139f Mon Sep 17 00:00:00 2001
From: John Livingston <git@john-livingston.fr>
Date: Wed, 11 Sep 2024 11:29:28 +0200
Subject: [PATCH] Update dependencies:

* update @tsconfig/nodes12 to @tsconfig/node16
* Peertube >= 5.2.0 required
---
 .github/dependabot.yml |  3 ---
 CHANGELOG.md           |  5 +++++
 package-lock.json      | 18 +++++++++---------
 package.json           |  4 ++--
 server/tsconfig.json   | 11 ++---------
 5 files changed, 18 insertions(+), 23 deletions(-)

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index 966ba17a..f21f8a6a 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -13,9 +13,6 @@ updates:
   - dependency-name: typescript
     versions:
     - ">=5.6.0" # linting libs are not ready for 5.6
-  - dependency-name: "@tsconfig/node12"
-    versions:
-    - ">=2.0.0" # breaks the config, must see why before updating
   - dependency-name: "@types/nodes"
     versions:
     - ">=17.0.0" # must be set to the Peertube required version.
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5815b9ed..180e079a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,11 @@
 TODO Before releasing:
 * update ConverseJS with latest merges.
 
+### Importante Notes
+
+This version requires Peertube 5.2.0 or superior.
+It also requires NodeJS 16 or superior (same as Peertube 5.2.0.)
+
 ### New features
 
 * #131: Emoji only mode.
diff --git a/package-lock.json b/package-lock.json
index af229ece..9debac41 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -28,7 +28,7 @@
         "@peertube/feed": "^5.1.3",
         "@peertube/peertube-types": "^5.2.0",
         "@stylistic/eslint-plugin": "^2.8.0",
-        "@tsconfig/node12": "^1.0.11",
+        "@tsconfig/node16": "^16.1.3",
         "@types/async": "^3.2.24",
         "@types/escape-html": "^1.0.4",
         "@types/eslint__js": "^8.42.3",
@@ -3698,10 +3698,10 @@
         "node": ">=10.13.0"
       }
     },
-    "node_modules/@tsconfig/node12": {
-      "version": "1.0.11",
-      "resolved": "https://registry.npmjs.org/@tsconfig/node12/-/node12-1.0.11.tgz",
-      "integrity": "sha512-cqefuRsh12pWyGsIoBKJA9luFu3mRxCA+ORZvA4ktLSzIuCUtWVxGIuXigEwO5/ywWFMZ2QEGKWvkZG1zDMTag==",
+    "node_modules/@tsconfig/node16": {
+      "version": "16.1.3",
+      "resolved": "https://registry.npmjs.org/@tsconfig/node16/-/node16-16.1.3.tgz",
+      "integrity": "sha512-9nTOUBn+EMKO6rtSZJk+DcqsfgtlERGT9XPJ5PRj/HNENPCBY1yu/JEj5wT6GLtbCLBO2k46SeXDaY0pjMqypw==",
       "dev": true
     },
     "node_modules/@types/async": {
@@ -15599,10 +15599,10 @@
       "integrity": "sha512-L7z9BgrNEcYyUYtF+HaEfiS5ebkh9jXqbszz7pC0hRBPaatV0XjSD3+eHrpqFemQfgwiFF0QPIarnIihIDn7OA==",
       "dev": true
     },
-    "@tsconfig/node12": {
-      "version": "1.0.11",
-      "resolved": "https://registry.npmjs.org/@tsconfig/node12/-/node12-1.0.11.tgz",
-      "integrity": "sha512-cqefuRsh12pWyGsIoBKJA9luFu3mRxCA+ORZvA4ktLSzIuCUtWVxGIuXigEwO5/ywWFMZ2QEGKWvkZG1zDMTag==",
+    "@tsconfig/node16": {
+      "version": "16.1.3",
+      "resolved": "https://registry.npmjs.org/@tsconfig/node16/-/node16-16.1.3.tgz",
+      "integrity": "sha512-9nTOUBn+EMKO6rtSZJk+DcqsfgtlERGT9XPJ5PRj/HNENPCBY1yu/JEj5wT6GLtbCLBO2k46SeXDaY0pjMqypw==",
       "dev": true
     },
     "@types/async": {
diff --git a/package.json b/package.json
index f7064277..1fad07a1 100644
--- a/package.json
+++ b/package.json
@@ -45,7 +45,7 @@
     "@peertube/feed": "^5.1.3",
     "@peertube/peertube-types": "^5.2.0",
     "@stylistic/eslint-plugin": "^2.8.0",
-    "@tsconfig/node12": "^1.0.11",
+    "@tsconfig/node16": "^16.1.3",
     "@types/async": "^3.2.24",
     "@types/escape-html": "^1.0.4",
     "@types/eslint__js": "^8.42.3",
@@ -76,7 +76,7 @@
     "yaml": "^2.5.1"
   },
   "engine": {
-    "peertube": ">=4.2.0"
+    "peertube": ">=5.2.0"
   },
   "engines": {
     "npm": ">=7"
diff --git a/server/tsconfig.json b/server/tsconfig.json
index b679eb99..483b0165 100644
--- a/server/tsconfig.json
+++ b/server/tsconfig.json
@@ -1,16 +1,9 @@
 {
-	"extends": "@tsconfig/node12/tsconfig.json",
+	"extends": "@tsconfig/node16/tsconfig.json",
 	"compilerOptions": {
-		"moduleResolution": "node", // Tell tsc to look in node_modules for modules
-		"strict": true, // That implies alwaysStrict, noImplicitAny, noImplicitThis
-
-		"alwaysStrict": true, // should already be true because of strict:true
-		"noImplicitAny": true, // should already be true because of strict:true
-		"noImplicitThis": true, // should already be true because of strict:true
 		"noImplicitReturns": true,
     "noImplicitOverride": true,
-		"strictBindCallApply": true, // should already be true because of strict:true
-		"noUnusedLocals": false, // works better as a linter error/warning
+		"noUnusedLocals": true,
 		"removeComments": true,
 		"sourceMap": true,