matty/peertube-plugin-livechat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #578 from JohnXLivingston/dependabot/npm_and_yarn/eslint-config-love-84.1.0

Browse Source 
Bump eslint-config-love from 66.0.0 to 84.1.0
This commit is contained in:
John Livingston 2024-10-08 17:23:50 +02:00 committed by GitHub
commit 1e97193030
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 23 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
client/common/admin/firewall/elements/admin-firewall.ts
View File

@ -103,7 +103,7 @@ export class AdminFirewallElement extends LivechatElement {
public readonly getInputValidationClass = (propertyName: string): Record<string, boolean> => { public readonly getInputValidationClass = (propertyName: string): Record<string, boolean> => {
const validationErrorTypes: ValidationErrorType[] | undefined = const validationErrorTypes: ValidationErrorType[] | undefined =
this.validationError?.properties[`${propertyName}`] this.validationError?.properties[propertyName]
return validationErrorTypes ? (validationErrorTypes.length ? { 'is-invalid': true } : { 'is-valid': true }) : {} return validationErrorTypes ? (validationErrorTypes.length ? { 'is-invalid': true } : { 'is-valid': true }) : {}
} }
@ -111,7 +111,7 @@ export class AdminFirewallElement extends LivechatElement {
propertyName: string): TemplateResult | typeof nothing => { propertyName: string): TemplateResult | typeof nothing => {
const errorMessages: TemplateResult[] = [] const errorMessages: TemplateResult[] = []
const validationErrorTypes: ValidationErrorType[] | undefined = const validationErrorTypes: ValidationErrorType[] | undefined =
this.validationError?.properties[`${propertyName}`] ?? undefined this.validationError?.properties[propertyName] ?? undefined
// FIXME: this code is duplicated in dymamic table form // FIXME: this code is duplicated in dymamic table form
if (validationErrorTypes && validationErrorTypes.length !== 0) { if (validationErrorTypes && validationErrorTypes.length !== 0) {

4
client/common/configuration/elements/channel-configuration.ts
View File

@ -115,7 +115,7 @@ export class ChannelConfigurationElement extends LivechatElement {
public readonly getInputValidationClass = (propertyName: string): Record<string, boolean> => { public readonly getInputValidationClass = (propertyName: string): Record<string, boolean> => {
const validationErrorTypes: ValidationErrorType[] | undefined = const validationErrorTypes: ValidationErrorType[] | undefined =
this.validationError?.properties[`${propertyName}`] this.validationError?.properties[propertyName]
return validationErrorTypes ? (validationErrorTypes.length ? { 'is-invalid': true } : { 'is-valid': true }) : {} return validationErrorTypes ? (validationErrorTypes.length ? { 'is-invalid': true } : { 'is-valid': true }) : {}
} }
@ -123,7 +123,7 @@ export class ChannelConfigurationElement extends LivechatElement {
propertyName: string): TemplateResult | typeof nothing => { propertyName: string): TemplateResult | typeof nothing => {
const errorMessages: TemplateResult[] = [] const errorMessages: TemplateResult[] = []
const validationErrorTypes: ValidationErrorType[] | undefined = const validationErrorTypes: ValidationErrorType[] | undefined =
this.validationError?.properties[`${propertyName}`] ?? undefined this.validationError?.properties[propertyName] ?? undefined
// FIXME: this code is duplicated in dymamic table form // FIXME: this code is duplicated in dymamic table form
if (validationErrorTypes && validationErrorTypes.length !== 0) { if (validationErrorTypes && validationErrorTypes.length !== 0) {

8
eslint.config.mjs
View File

@ -71,6 +71,14 @@ export default tseslint.config(
'@typescript-eslint/class-methods-use-this': 'off', '@typescript-eslint/class-methods-use-this': 'off',
'@typescript-eslint/non-nullable-type-assertion-style': 'off', '@typescript-eslint/non-nullable-type-assertion-style': 'off',
'@typescript-eslint/no-magic-numbers': 'off', '@typescript-eslint/no-magic-numbers': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off', // FIXME: comes with eslint-config-love 84 update, and should be used.
'@typescript-eslint/no-unsafe-return': 'off', // FIXME: comes with eslint-config-love 84 update, and should be used.
'@typescript-eslint/no-unsafe-assignment': 'off', // FIXME: comes with eslint-config-love 84 update, and should be used.
'@typescript-eslint/no-unsafe-call': 'off', // FIXME: comes with eslint-config-love 84 update, and should be used.
'@typescript-eslint/no-unnecessary-condition': 'off', // FIXME: comes with eslint-config-love 84 update, but seems buggy (false positive).
'max-len': [ 'max-len': [
'error', 'error',
{ {

14
package-lock.json generated
View File

@ -42,7 +42,7 @@
"commander": "^12.1.0", "commander": "^12.1.0",
"esbuild": "^0.24.0", "esbuild": "^0.24.0",
"eslint": "^8.57.1", "eslint": "^8.57.1",
"eslint-config-love": "^66.0.0", "eslint-config-love": "^84.1.0",
"eslint-plugin-lit": "^1.15.0", "eslint-plugin-lit": "^1.15.0",
"globals": "^15.10.0", "globals": "^15.10.0",
"lit": "^3.2.1", "lit": "^3.2.1",
@ -6581,9 +6581,9 @@
} }
}, },
"node_modules/eslint-config-love": { "node_modules/eslint-config-love": {
"version": "66.0.0", "version": "84.1.0",
"resolved": "https://registry.npmjs.org/eslint-config-love/-/eslint-config-love-66.0.0.tgz", "resolved": "https://registry.npmjs.org/eslint-config-love/-/eslint-config-love-84.1.0.tgz",
"integrity": "sha512-Op6YXKED9jFjdrg0wA/pUcnMla0IO0oN5S0OLRykboCa00ilLS82+dXoeIGMIBI0Q7Ik03X9fOes+jXZ4yL7pQ==", "integrity": "sha512-nrFAu5fnlAhEvluQ72nR0DG6YZ/7woREmr8QMi69f+ad55LosQ62UKDQw4o9Bwb8ye7deoPm1FTMUorzgL9ZHQ==",
"dev": true, "dev": true,
"funding": [ "funding": [
{ {
@ -17812,9 +17812,9 @@
} }
}, },
"eslint-config-love": { "eslint-config-love": {
"version": "66.0.0", "version": "84.1.0",
"resolved": "https://registry.npmjs.org/eslint-config-love/-/eslint-config-love-66.0.0.tgz", "resolved": "https://registry.npmjs.org/eslint-config-love/-/eslint-config-love-84.1.0.tgz",
"integrity": "sha512-Op6YXKED9jFjdrg0wA/pUcnMla0IO0oN5S0OLRykboCa00ilLS82+dXoeIGMIBI0Q7Ik03X9fOes+jXZ4yL7pQ==", "integrity": "sha512-nrFAu5fnlAhEvluQ72nR0DG6YZ/7woREmr8QMi69f+ad55LosQ62UKDQw4o9Bwb8ye7deoPm1FTMUorzgL9ZHQ==",
"dev": true, "dev": true,
"requires": { "requires": {
"eslint-plugin-import": "^2.25.2", "eslint-plugin-import": "^2.25.2",

2
package.json
View File

@ -59,7 +59,7 @@
"commander": "^12.1.0", "commander": "^12.1.0",
"esbuild": "^0.24.0", "esbuild": "^0.24.0",
"eslint": "^8.57.1", "eslint": "^8.57.1",
"eslint-config-love": "^66.0.0", "eslint-config-love": "^84.1.0",
"eslint-plugin-lit": "^1.15.0", "eslint-plugin-lit": "^1.15.0",
"globals": "^15.10.0", "globals": "^15.10.0",
"lit": "^3.2.1", "lit": "^3.2.1",

1
server/lib/external-auth/oidc.ts
View File

@ -757,6 +757,7 @@ class ExternalAuthOIDC {
* @throws Error * @throws Error
* @returns the singleton * @returns the singleton
*/ */
// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
public static singleton (singletonType: ExternalAuthOIDCType | string): ExternalAuthOIDC { public static singleton (singletonType: ExternalAuthOIDCType | string): ExternalAuthOIDC {
if (!singletons) { if (!singletons) {
throw new Error('ExternalAuthOIDC singletons are not initialized yet') throw new Error('ExternalAuthOIDC singletons are not initialized yet')

1
server/lib/federation/storage.ts
View File

@ -307,6 +307,7 @@ async function _store (options: RegisterServerOptions, filePath: string, content
} }
} }
// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
async function _get (options: RegisterServerOptions, filePath: string): Promise<any | null> { async function _get (options: RegisterServerOptions, filePath: string): Promise<any | null> {
const logger = options.peertubeHelpers.logger const logger = options.peertubeHelpers.logger
try { try {

1
server/lib/routers/webchat.ts
View File

@ -142,6 +142,7 @@ async function initWebchatRouter (options: RegisterServerOptionsV5): Promise<Rou
res.status(200) res.status(200)
res.type('html') res.type('html')
res.send(page) res.send(page)
// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
} catch (err: LivechatError | any) { } catch (err: LivechatError | any) {
const code = err.livechatError?.code ?? 500 const code = err.livechatError?.code ?? 500
const additionnalMessage: string = escapeHTML(err.livechatError?.message as string ?? '') const additionnalMessage: string = escapeHTML(err.livechatError?.message as string ?? '')