matty/peertube-plugin-livechat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Dynamic table: refactoring (more readable code).

Browse Source
This commit is contained in:
John Livingston 2024-06-13 12:31:23 +02:00
parent b6f196d07c
commit 1d943716dd
No known key found for this signature in database
GPG Key ID: B17B5640CE66CDBC
1 changed files with 31 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
client/common/lib/elements/dynamic-table-form.ts
View File

@ -188,11 +188,11 @@ export class DynamicTableFormElement extends LivechatElement {
this._updateLastRowId() this._updateLastRowId()
// Filter removed rows // Filter removed rows
// FIXME: seems buggy. Missing assignation? // FIXME: is this really necessary?
this._rowsById.filter(rowById => this.rows.includes(rowById.row)) this._rowsById = this._rowsById.filter(rowById => this.rows.includes(rowById.row))
for (let i = 0; i < this.rows.length; i++) { for (let i = 0; i < this.rows.length; i++) {
if (this._rowsById.filter(rowById => rowById.row === this.rows[i]).length === 0) { if (!this._rowsById.find(rowById => rowById.row === this.rows[i])) {
// Add row and assign id // Add row and assign id
this._rowsById.push({ _id: this._lastRowId++, _originalIndex: i, row: this.rows[i] }) this._rowsById.push({ _id: this._lastRowId++, _originalIndex: i, row: this.rows[i] })
} else { } else {
@ -722,35 +722,35 @@ export class DynamicTableFormElement extends LivechatElement {
: target.value : target.value
: undefined : undefined
if (value !== undefined) { if (value === undefined) {
for (const rowById of this._rowsById) {
if (rowById._id === rowId) {
switch (propertySchema.default?.constructor) {
case Array:
if (value.constructor === Array || !propertySchema.separator) {
rowById.row[propertyName] = value
} else {
rowById.row[propertyName] = (value as string)
.split(propertySchema.separator)
}
break
default:
rowById.row[propertyName] = value
break
}
this.rows = this._rowsById.map(rowById => rowById.row)
this.requestUpdate('rows')
this.requestUpdate('_rowsById')
this.dispatchEvent(new CustomEvent('update', { detail: this.rows }))
return
}
}
console.warn(`Could not update property : Did not find a property named '${propertyName}' in row '${rowId}'`)
} else {
console.warn('Could not update property : Target or value was undefined') console.warn('Could not update property : Target or value was undefined')
return
} }
const rowById = this._rowsById.find(rowById => rowById._id === rowId)
if (!rowById) {
console.warn(`Could not update property : Did not find a property named '${propertyName}' in row '${rowId}'`)
return
}
switch (propertySchema.default?.constructor) {
case Array:
if (value.constructor === Array || !propertySchema.separator) {
rowById.row[propertyName] = value
} else {
rowById.row[propertyName] = (value as string)
.split(propertySchema.separator)
}
break
default:
rowById.row[propertyName] = value
break
}
this.rows = this._rowsById.map(rowById => rowById.row)
this.requestUpdate('rows')
this.requestUpdate('_rowsById')
this.dispatchEvent(new CustomEvent('update', { detail: this.rows }))
} }
} }