From efb3097c800c26847c50c1794ddf9fc805650011 Mon Sep 17 00:00:00 2001 From: oakes Date: Wed, 2 Aug 2023 15:29:01 -0400 Subject: [PATCH 1/2] Set default for 'checked' property --- app/soapbox/components/ui/toggle/toggle.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/soapbox/components/ui/toggle/toggle.tsx b/app/soapbox/components/ui/toggle/toggle.tsx index abf7933c5..1b34dde3c 100644 --- a/app/soapbox/components/ui/toggle/toggle.tsx +++ b/app/soapbox/components/ui/toggle/toggle.tsx @@ -6,7 +6,7 @@ interface IToggle extends Pick, 'id' } /** A glorified checkbox. */ -const Toggle: React.FC = ({ id, size = 'md', name, checked, onChange, required, disabled }) => { +const Toggle: React.FC = ({ id, size = 'md', name, checked = false, onChange, required, disabled }) => { const input = useRef(null); const handleClick: React.MouseEventHandler = () => { From c384aa6db2ce02c80a8bb2ec158387c9ddd66d07 Mon Sep 17 00:00:00 2001 From: oakes Date: Wed, 2 Aug 2023 15:38:50 -0400 Subject: [PATCH 2/2] Pass id to useEffect so it runs when id changes --- app/soapbox/features/hashtag-timeline/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/soapbox/features/hashtag-timeline/index.tsx b/app/soapbox/features/hashtag-timeline/index.tsx index 69cc0cd60..df0c05236 100644 --- a/app/soapbox/features/hashtag-timeline/index.tsx +++ b/app/soapbox/features/hashtag-timeline/index.tsx @@ -41,7 +41,7 @@ export const HashtagTimeline: React.FC = ({ params }) => { useEffect(() => { dispatch(expandHashtagTimeline(id)); dispatch(fetchHashtag(id)); - }, []); + }, [id]); useEffect(() => { dispatch(clearTimeline(`hashtag:${id}`));