matty/ncd-fe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer to/href for DropdownMenuItems

Browse Source 
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
This commit is contained in:
marcin mikołajczak
2024-04-28 11:24:59 +02:00
parent 0b2e370705
commit fd65f7f71e
4 changed files with 10 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/components/dropdown-menu/dropdown-menu-item.tsx
View File

@ -33,6 +33,7 @@ const DropdownMenuItem = ({ index, item, onClick }: IDropdownMenuItem) => {
event.stopPropagation();
if (!item) return;
if (onClick) onClick();
if (item.to) {

13
src/components/status-action-bar.tsx
View File

@ -211,10 +211,6 @@ const StatusActionBar: React.FC<IStatusActionBar> = ({
}));
};
const handleExternalClick = () => {
window.open(status.uri, '_blank');
};
const handleReblogClick: React.EventHandler<React.MouseEvent> = e => {
if (me) {
const modalReblog = () => dispatch(toggleReblog(status));
@ -336,10 +332,6 @@ const StatusActionBar: React.FC<IStatusActionBar> = ({
}));
};
const handleOpen: React.EventHandler<React.MouseEvent> = (e) => {
history.push(`/@${status.account.acct}/posts/${status.id}`);
};
const handleEmbed = () => {
dispatch(openModal('EMBED', {
url: status.url,
@ -417,8 +409,8 @@ const StatusActionBar: React.FC<IStatusActionBar> = ({
if (expandable) {
menu.push({
text: intl.formatMessage(messages.open),
action: handleOpen,
icon: require('@tabler/icons/outline/arrows-vertical.svg'),
to: `/@${status.account.acct}/posts/${status.id}`,
});
}
@ -475,8 +467,9 @@ const StatusActionBar: React.FC<IStatusActionBar> = ({
const { hostname: domain } = new URL(status.uri);
menu.push({
text: intl.formatMessage(messages.external, { domain }),
action: handleExternalClick,
icon: require('@tabler/icons/outline/external-link.svg'),
href: status.uri,
target: '_blank',
});
}