Expand timelines loading state fix, improve search behavior

Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
This commit is contained in:
marcin mikołajczak
2024-08-22 17:40:50 +02:00
parent 2abf4a4c8c
commit f705e14d2e
8 changed files with 65 additions and 63 deletions

View File

@ -47,12 +47,13 @@ const SearchResults = () => {
const filterByAccount = useAppSelector((state) => state.search.accountId || undefined);
const { trendingLinks } = useTrendingLinks();
const { account } = useAccount(filterByAccount);
useAppSelector((state) => console.log(state.search.toJS()));
const handleLoadMore = () => dispatch(expandSearch(selectedFilter));
const handleUnsetAccount = () => dispatch(setSearchAccount(null));
const selectFilter = (newActiveFilter: SearchFilter) => dispatch(setFilter(newActiveFilter));
const selectFilter = (newActiveFilter: SearchFilter) => dispatch(setFilter(value, newActiveFilter));
const renderFilterBar = () => {
const items = [];
@ -207,6 +208,8 @@ const SearchResults = () => {
}
if (selectedFilter === 'links') {
loaded = true;
if (submitted) {
selectFilter('accounts');
setTabKey(key => ++key);
@ -214,6 +217,8 @@ const SearchResults = () => {
searchResults = ImmutableList(trendingLinks.map(trendingLink => <TrendingLink trendingLink={trendingLink} />));
}
}
console.log(submitted, loaded, selectedFilter);
return (
<>

View File

@ -1,11 +1,10 @@
import clsx from 'clsx';
import debounce from 'lodash/debounce';
import React, { useCallback } from 'react';
import React, { useCallback, useEffect, useState } from 'react';
import { defineMessages, useIntl } from 'react-intl';
import { useHistory } from 'react-router-dom';
import {
changeSearch,
clearSearch,
clearSearchResults,
setSearchAccount,
@ -41,6 +40,8 @@ interface ISearch {
}
const Search = (props: ISearch) => {
const submittedValue = useAppSelector((state) => state.search.submittedValue);
const [value, setValue] = useState(submittedValue);
const {
autoFocus = false,
autoSubmit = false,
@ -52,20 +53,19 @@ const Search = (props: ISearch) => {
const history = useHistory();
const intl = useIntl();
const value = useAppSelector((state) => state.search.value);
const submitted = useAppSelector((state) => state.search.submitted);
const debouncedSubmit = useCallback(debounce(() => {
dispatch(submitSearch());
const debouncedSubmit = useCallback(debounce((value: string) => {
dispatch(submitSearch(value));
}, 900), []);
const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => {
const { value } = event.target;
dispatch(changeSearch(value));
setValue(value);
if (autoSubmit) {
debouncedSubmit();
debouncedSubmit(value);
}
};
@ -80,11 +80,11 @@ const Search = (props: ISearch) => {
const handleSubmit = () => {
if (openInRoute) {
dispatch(setSearchAccount(null));
dispatch(submitSearch());
dispatch(submitSearch(value));
history.push('/search');
} else {
dispatch(submitSearch());
dispatch(submitSearch(value));
}
};
@ -129,6 +129,10 @@ const Search = (props: ISearch) => {
className: 'pr-10 rtl:pl-10 rtl:pr-3',
};
useEffect(() => {
if (value !== submittedValue) setValue(submittedValue);
}, [submittedValue]);
if (autosuggest) {
componentProps.onSelected = handleSelected;
componentProps.menu = makeMenu();