From d49eb6e1697bb68722a8c25cee002e1b42d7de82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?nicole=20miko=C5=82ajczyk?= Date: Fri, 16 Jan 2026 00:45:45 +0100 Subject: [PATCH] Revert "pl-fe: improve local users domain display with displayFqn === true" This reverts commit cb00bf85cc00c0c66d40a8805e5685298274ba45. --- packages/pl-fe/src/components/account.tsx | 5 +++-- .../ui/components/panels/user-panel.tsx | 8 +++++--- packages/pl-fe/src/hooks/use-acct.ts | 20 ------------------- packages/pl-fe/src/layouts/profile-layout.tsx | 7 ++++--- 4 files changed, 12 insertions(+), 28 deletions(-) delete mode 100644 packages/pl-fe/src/hooks/use-acct.ts diff --git a/packages/pl-fe/src/components/account.tsx b/packages/pl-fe/src/components/account.tsx index 7dfeb31de..607a3f076 100644 --- a/packages/pl-fe/src/components/account.tsx +++ b/packages/pl-fe/src/components/account.tsx @@ -14,9 +14,10 @@ import Text from 'pl-fe/components/ui/text'; import VerificationBadge from 'pl-fe/components/verification-badge'; import Emojify from 'pl-fe/features/emoji/emojify'; import ActionButton from 'pl-fe/features/ui/components/action-button'; -import { useAcct } from 'pl-fe/hooks/use-acct'; import { useAppSelector } from 'pl-fe/hooks/use-app-selector'; import { useSettings } from 'pl-fe/stores/settings'; +import { getAcct } from 'pl-fe/utils/accounts'; +import { displayFqn } from 'pl-fe/utils/state'; import Badge from './badge'; import { ParsedContent } from './parsed-content'; @@ -147,7 +148,7 @@ const Account = ({ const [style, setStyle] = useState({}); const me = useAppSelector((state) => state.me); - const username = useAcct(account); + const username = useAppSelector((state) => account ? getAcct(account, displayFqn(state)) : null); const { disableUserProvidedMedia } = useSettings(); const handleAction = () => { diff --git a/packages/pl-fe/src/features/ui/components/panels/user-panel.tsx b/packages/pl-fe/src/features/ui/components/panels/user-panel.tsx index aaced57a1..1f89e7620 100644 --- a/packages/pl-fe/src/features/ui/components/panels/user-panel.tsx +++ b/packages/pl-fe/src/features/ui/components/panels/user-panel.tsx @@ -11,9 +11,11 @@ import Stack from 'pl-fe/components/ui/stack'; import Text from 'pl-fe/components/ui/text'; import VerificationBadge from 'pl-fe/components/verification-badge'; import Emojify from 'pl-fe/features/emoji/emojify'; -import { useAcct } from 'pl-fe/hooks/use-acct'; +import { useAppSelector } from 'pl-fe/hooks/use-app-selector'; import { useSettings } from 'pl-fe/stores/settings'; +import { getAcct } from 'pl-fe/utils/accounts'; import { shortNumberFormat } from 'pl-fe/utils/numbers'; +import { displayFqn } from 'pl-fe/utils/state'; const messages = defineMessages({ account_locked: { id: 'account.locked_info', defaultMessage: 'This account privacy status is set to locked. The owner manually reviews who can follow them.' }, @@ -30,7 +32,7 @@ const UserPanel: React.FC = ({ accountId, action, badges, domain }) const intl = useIntl(); const { demetricator, disableUserProvidedMedia } = useSettings(); const { account } = useAccount(accountId); - const displayedAcct = useAcct(account); + const fqn = useAppSelector((state) => displayFqn(state)); if (!account) return null; const acct = !account.acct.includes('@') && domain ? `${account.acct}@${domain}` : account.acct; @@ -94,7 +96,7 @@ const UserPanel: React.FC = ({ accountId, action, badges, domain }) - @{displayedAcct} + @{getAcct(account, fqn)} {account.locked && ( diff --git a/packages/pl-fe/src/hooks/use-acct.ts b/packages/pl-fe/src/hooks/use-acct.ts deleted file mode 100644 index ce3b112ea..000000000 --- a/packages/pl-fe/src/hooks/use-acct.ts +++ /dev/null @@ -1,20 +0,0 @@ -import { displayFqn } from 'pl-fe/utils/state'; - -import { useAppSelector } from './use-app-selector'; -import { useInstance } from './use-instance'; - -import type { Account } from 'pl-api'; - -const useAcct = (account?: Pick): string | undefined => { - const fqn = useAppSelector((state) => displayFqn(state)); - const instance = useInstance(); - - if (!account) return; - if (!fqn) return account.acct; - if (account.local === false) return account.fqn; - return `${account.acct}@${instance.domain}`; -}; - -export { - useAcct, -}; diff --git a/packages/pl-fe/src/layouts/profile-layout.tsx b/packages/pl-fe/src/layouts/profile-layout.tsx index 1694b1d2b..b39cfaa94 100644 --- a/packages/pl-fe/src/layouts/profile-layout.tsx +++ b/packages/pl-fe/src/layouts/profile-layout.tsx @@ -19,9 +19,10 @@ import { PinnedAccountsPanel, AccountNotePanel, } from 'pl-fe/features/ui/util/async-components'; -import { useAcct } from 'pl-fe/hooks/use-acct'; import { useAppSelector } from 'pl-fe/hooks/use-app-selector'; import { useFeatures } from 'pl-fe/hooks/use-features'; +import { usePlFeConfig } from 'pl-fe/hooks/use-pl-fe-config'; +import { getAcct } from 'pl-fe/utils/accounts'; /** Layout to display a user's profile. */ const ProfileLayout: React.FC = () => { @@ -32,7 +33,7 @@ const ProfileLayout: React.FC = () => { const me = useAppSelector(state => state.me); const features = useFeatures(); - const acct = useAcct(account); + const { displayFqn } = usePlFeConfig(); if (isUnauthorized) { localStorage.setItem('plfe:redirect_uri', location.href); @@ -100,7 +101,7 @@ const ProfileLayout: React.FC = () => { )} - +