diff --git a/packages/pl-fe/src/components/media-gallery.tsx b/packages/pl-fe/src/components/media-gallery.tsx index 3ea6c3f71..6da512246 100644 --- a/packages/pl-fe/src/components/media-gallery.tsx +++ b/packages/pl-fe/src/components/media-gallery.tsx @@ -329,9 +329,7 @@ const MediaGallery: React.FC = (props) => { const style: React.CSSProperties = {}; let itemsDimensions: Dimensions[] = []; - const ratios = Array(size).fill(null).map((_, i) => - getAspectRatio(media[i]) as number, - ); + const ratios = Array(size).fill(null).map((_, i) => getAspectRatio(media[i])); const [ar1, ar2, ar3, ar4] = ratios; diff --git a/packages/pl-fe/src/utils/media-aspect-ratio.ts b/packages/pl-fe/src/utils/media-aspect-ratio.ts index 5034677cd..30b429633 100644 --- a/packages/pl-fe/src/utils/media-aspect-ratio.ts +++ b/packages/pl-fe/src/utils/media-aspect-ratio.ts @@ -1,18 +1,18 @@ const minimumAspectRatio = 9 / 16; // Portrait phone const maximumAspectRatio = 10; // Generous min-height -const isPanoramic = (ar: number) => { - if (isNaN(ar)) return false; +const isPanoramic = (ar: number | null) => { + if (ar === null || isNaN(ar)) return false; return ar >= maximumAspectRatio; }; -const isPortrait = (ar: number) => { - if (isNaN(ar)) return false; +const isPortrait = (ar: number | null) => { + if (ar === null || isNaN(ar)) return false; return ar <= minimumAspectRatio; }; -const isNonConformingRatio = (ar: number) => { - if (isNaN(ar)) return false; +const isNonConformingRatio = (ar: number | null) => { + if (ar === null || isNaN(ar)) return false; return !isPanoramic(ar) && !isPortrait(ar); };