componentWillReceiveProps fixes, fixes #184, #231, !80

2020-07-04 18:41:41 -05:00
parent 75ab969051
commit 853dad032c
25 changed files with 119 additions and 120 deletions
--- a/app/soapbox/features/groups/edit/index.js
+++ b/app/soapbox/features/groups/edit/index.js
@ -55,16 +55,14 @@ class Edit extends React.PureComponent {
    setUp: PropTypes.func.isRequired,
  };

-  constructor(nextProps) {
-    super(nextProps);
-    if (this.props.group) {
-      this.props.setUp(this.props.group);
-    }
+  constructor(props) {
+    super(props);
+    if (props.group) props.setUp(props.group);
  }

-  componentDidUpdate(nextProps) {
-    if (!this.props.group && nextProps.group) {
-      this.props.setUp(nextProps.group);
+  componentDidUpdate(prevProps) {
+    if (!prevProps.group && this.props.group) {
+      this.props.setUp(this.props.group);
    }
  }