matty/ncd-fe
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

componentWillReceiveProps fixes, fixes #184, #231, !80

Browse Source
This commit is contained in:
Alex Gleason
2020-07-04 18:41:41 -05:00
parent 75ab969051
commit 853dad032c
25 changed files with 119 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/soapbox/features/groups/edit/index.js
View File

@@ -55,16 +55,14 @@ class Edit extends React.PureComponent {
setUp: PropTypes.func.isRequired,
};
constructor(nextProps) {
super(nextProps);
if (this.props.group) {
this.props.setUp(this.props.group);
}
constructor(props) {
super(props);
if (props.group) props.setUp(props.group);
}
componentDidUpdate(nextProps) {
if (!this.props.group && nextProps.group) {
this.props.setUp(nextProps.group);
componentDidUpdate(prevProps) {
if (!prevProps.group && this.props.group) {
this.props.setUp(this.props.group);
}
}

6
app/soapbox/features/groups/members/index.js
View File

@@ -36,9 +36,9 @@ class GroupMembers extends ImmutablePureComponent {
this.props.dispatch(fetchMembers(id));
}
componentDidUpdate(nextProps) {
if (nextProps.params.id !== this.props.params.id) {
this.props.dispatch(fetchMembers(nextProps.params.id));
componentDidUpdate(prevProps) {
if (this.props.params.id !== prevProps.params.id) {
this.props.dispatch(fetchMembers(this.props.params.id));
}
}

6
app/soapbox/features/groups/removed_accounts/index.js
View File

@@ -43,9 +43,9 @@ class GroupRemovedAccounts extends ImmutablePureComponent {
this.props.dispatch(fetchRemovedAccounts(id));
}
componentDidUpdate(nextProps) {
if (nextProps.params.id !== this.props.params.id) {
this.props.dispatch(fetchRemovedAccounts(nextProps.params.id));
componentDidUpdate(prevProps) {
if (this.props.params.id !== prevProps.params.id) {
this.props.dispatch(fetchRemovedAccounts(this.props.params.id));
}
}