From 34b83c8ad34759df45b38e9b735da5b2d770d3f9 Mon Sep 17 00:00:00 2001
From: Alex Gleason <alex@alexgleason.me>
Date: Wed, 20 Apr 2022 12:24:03 -0500
Subject: [PATCH] Onboarding: improve rendering of empty suggestions

---
 .../steps/suggested-accounts-step.tsx         | 48 +++++++++++++------
 1 file changed, 34 insertions(+), 14 deletions(-)

diff --git a/app/soapbox/features/onboarding/steps/suggested-accounts-step.tsx b/app/soapbox/features/onboarding/steps/suggested-accounts-step.tsx
index 027882d21..b8ef40ccc 100644
--- a/app/soapbox/features/onboarding/steps/suggested-accounts-step.tsx
+++ b/app/soapbox/features/onboarding/steps/suggested-accounts-step.tsx
@@ -19,9 +19,39 @@ const SuggestedAccountsStep = ({ onNext }: { onNext: () => void }) => {
     dispatch(fetchSuggestions());
   }, []);
 
-  if (suggestionsToRender.isEmpty()) {
-    return null;
-  }
+  const renderSuggestions = () => {
+    return (
+      <div className='sm:pt-4 sm:pb-10 flex flex-col divide-y divide-solid divide-gray-200'>
+        {suggestionsToRender.map((suggestion: ImmutableMap<string, any>) => (
+          <div key={suggestion.get('account')} className='py-2'>
+            <AccountContainer
+              // @ts-ignore: TS thinks `id` is passed to <Account>, but it isn't
+              id={suggestion.get('account')}
+              showProfileHoverCard={false}
+            />
+          </div>
+        ))}
+      </div>
+    );
+  };
+
+  const renderEmpty = () => {
+    return (
+      <div className='bg-primary-50 dark:bg-slate-700 my-2 rounded-lg text-center p-8'>
+        <Text>
+          <FormattedMessage id='empty_column.follow_recommendations' defaultMessage='Looks like no suggestions could be generated for you. You can try using search to look for people you might know or explore trending hashtags.' />
+        </Text>
+      </div>
+    );
+  };
+
+  const renderBody = () => {
+    if (suggestionsToRender.isEmpty()) {
+      return renderEmpty();
+    } else {
+      return renderSuggestions();
+    }
+  };
 
   return (
     <Card variant='rounded' size='xl'>
@@ -39,17 +69,7 @@ const SuggestedAccountsStep = ({ onNext }: { onNext: () => void }) => {
             </Stack>
           </div>
 
-          <div className='sm:pt-4 sm:pb-10 flex flex-col divide-y divide-solid divide-gray-200'>
-            {suggestionsToRender.map((suggestion: ImmutableMap<string, any>) => (
-              <div key={suggestion.get('account')} className='py-2'>
-                <AccountContainer
-                  // @ts-ignore: TS thinks `id` is passed to <Account>, but it isn't
-                  id={suggestion.get('account')}
-                  showProfileHoverCard={false}
-                />
-              </div>
-            ))}
-          </div>
+          {renderBody()}
 
           <div className='sm:w-2/3 md:w-1/2 mx-auto'>
             <Stack>