From 2fc00472bf4a89e10cfd9cceeb21954044906049 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?nicole=20miko=C5=82ajczyk?= Date: Fri, 27 Feb 2026 01:17:07 +0100 Subject: [PATCH] pl-api: enable consistent-type-imports rule MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: nicole mikołajczyk --- packages/pl-api/.oxlintrc.json | 13 +++++++++++-- packages/pl-api/lib/client.ts | 4 +++- packages/pl-api/lib/client/grouped-notifications.ts | 3 ++- packages/pl-api/lib/client/my-account.ts | 7 +++---- packages/pl-api/lib/params/chats.ts | 2 +- packages/pl-api/lib/params/circles.ts | 2 +- packages/pl-api/lib/params/events.ts | 2 +- packages/pl-api/lib/params/interaction-requests.ts | 2 +- packages/pl-api/lib/params/statuses.ts | 3 +-- 9 files changed, 24 insertions(+), 14 deletions(-) diff --git a/packages/pl-api/.oxlintrc.json b/packages/pl-api/.oxlintrc.json index 92d30f12c..f59b767bf 100644 --- a/packages/pl-api/.oxlintrc.json +++ b/packages/pl-api/.oxlintrc.json @@ -16,14 +16,23 @@ "error", { "vars": "all", - "args": "none", + "args": "after-used", "ignoreRestSiblings": true, "caughtErrors": "none", "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" } ], - "no-shadow": "off" + "no-shadow": "off", + + "typescript/consistent-type-imports": [ + "error", + { "prefer": "type-imports", "fixStyle": "inline-type-imports" } + ], + "typescript/consistent-type-exports": [ + "error", + { "fixMixedExportsWithInlineTypeSpecifier": true } + ] }, "settings": { "jsx-a11y": { diff --git a/packages/pl-api/lib/client.ts b/packages/pl-api/lib/client.ts index 744ed79ff..1bfd2a7ba 100644 --- a/packages/pl-api/lib/client.ts +++ b/packages/pl-api/lib/client.ts @@ -37,13 +37,15 @@ import { trends } from './client/trends'; import { utils } from './client/utils'; import { ICESHRIMP_NET } from './features'; +import type { Instance } from './entities/instance'; + interface PlApiClientFullConstructorOpts extends PlApiClientConstructorOpts { /** Fetch instance after constructing */ fetchInstance?: boolean; /** Abort signal which can be used to cancel the callbacks */ fetchInstanceSignal?: AbortSignal; /** Executed after the initial instance fetch */ - onInstanceFetchSuccess?: (instance: import('./entities/instance').Instance) => void; + onInstanceFetchSuccess?: (instance: Instance) => void; /** Executed when the initial instance fetch failed */ onInstanceFetchError?: (error?: any) => void; } diff --git a/packages/pl-api/lib/client/grouped-notifications.ts b/packages/pl-api/lib/client/grouped-notifications.ts index ddae4af57..acb3d1c92 100644 --- a/packages/pl-api/lib/client/grouped-notifications.ts +++ b/packages/pl-api/lib/client/grouped-notifications.ts @@ -18,6 +18,7 @@ import type { GetUnreadNotificationGroupCountParams, } from '../params/grouped-notifications'; import type { PaginatedResponse } from '../responses'; +import type { notifications } from './notifications'; type EmptyObject = Record; @@ -104,7 +105,7 @@ const _groupNotifications = ( */ const groupedNotifications = ( client: PlApiBaseClient & { - notifications: ReturnType; + notifications: ReturnType; }, ) => { const category = { diff --git a/packages/pl-api/lib/client/my-account.ts b/packages/pl-api/lib/client/my-account.ts index 861179afa..9a09d2023 100644 --- a/packages/pl-api/lib/client/my-account.ts +++ b/packages/pl-api/lib/client/my-account.ts @@ -25,11 +25,12 @@ import type { UpdateBookmarkFolderParams, } from '../params/my-account'; import type { PaginatedResponse } from '../responses'; +import type { accounts } from './accounts'; type EmptyObject = Record; const paginatedIceshrimpAccountsList = async ( - client: PlApiBaseClient & { accounts: ReturnType }, + client: PlApiBaseClient & { accounts: ReturnType }, url: string, fn: (body: T) => Array, ): Promise> => { @@ -51,9 +52,7 @@ const paginatedIceshrimpAccountsList = async ( }; }; -const myAccount = ( - client: PlApiBaseClient & { accounts: ReturnType }, -) => ({ +const myAccount = (client: PlApiBaseClient & { accounts: ReturnType }) => ({ /** * View bookmarked statuses * Statuses the user has bookmarked. diff --git a/packages/pl-api/lib/params/chats.ts b/packages/pl-api/lib/params/chats.ts index 348f392eb..bb668207d 100644 --- a/packages/pl-api/lib/params/chats.ts +++ b/packages/pl-api/lib/params/chats.ts @@ -1,4 +1,4 @@ -import { PaginationParams, WithMutedParam } from './common'; +import type { PaginationParams, WithMutedParam } from './common'; /** * @category Request params diff --git a/packages/pl-api/lib/params/circles.ts b/packages/pl-api/lib/params/circles.ts index 422f3ddb6..b41ba5cf1 100644 --- a/packages/pl-api/lib/params/circles.ts +++ b/packages/pl-api/lib/params/circles.ts @@ -1,4 +1,4 @@ -import { PaginationParams } from './common'; +import type { PaginationParams } from './common'; /** * @category Request params diff --git a/packages/pl-api/lib/params/events.ts b/packages/pl-api/lib/params/events.ts index 4b40ab030..d2a835773 100644 --- a/packages/pl-api/lib/params/events.ts +++ b/packages/pl-api/lib/params/events.ts @@ -1,4 +1,4 @@ -import { PaginationParams } from './common'; +import type { PaginationParams } from './common'; /** * @category Request params diff --git a/packages/pl-api/lib/params/interaction-requests.ts b/packages/pl-api/lib/params/interaction-requests.ts index cb06ce92a..ea40c93c3 100644 --- a/packages/pl-api/lib/params/interaction-requests.ts +++ b/packages/pl-api/lib/params/interaction-requests.ts @@ -1,4 +1,4 @@ -import { PaginationParams } from './common'; +import type { PaginationParams } from './common'; /** * @category Request params diff --git a/packages/pl-api/lib/params/statuses.ts b/packages/pl-api/lib/params/statuses.ts index 577e7b0ea..04c87968f 100644 --- a/packages/pl-api/lib/params/statuses.ts +++ b/packages/pl-api/lib/params/statuses.ts @@ -1,6 +1,5 @@ -import { UpdateInteractionPoliciesParams } from './settings'; - import type { PaginationParams } from './common'; +import type { UpdateInteractionPoliciesParams } from './settings'; /** * @category Request params